Do not keep the build directory of the pinned packages#6436
Merged
rjbou merged 2 commits intoocaml:masterfrom Apr 4, 2025
Merged
Do not keep the build directory of the pinned packages#6436rjbou merged 2 commits intoocaml:masterfrom
rjbou merged 2 commits intoocaml:masterfrom
Conversation
2716628 to
fe1a71d
Compare
rjbou
reviewed
Apr 3, 2025
Collaborator
rjbou
left a comment
There was a problem hiding this comment.
I've exported the test to its own test file, to add more test for the OPAMKEEPBUILDDIR environment variable. It may worth to add some test with --keep-build-dir?
fe1a71d to
9c53c3b
Compare
9c53c3b to
d63df08
Compare
Member
Author
done. I've also extended your new reftest with the missing "repository package with local and vcs sources" cases |
d63df08 to
47962aa
Compare
Co-authored-by: Kate <kit-ty-kate@outlook.com>
47962aa to
047c2cd
Compare
1 task
rjbou
added a commit
to rjbou/opam
that referenced
this pull request
Jun 16, 2025
This was referenced Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4255 for good
Partially f.i.x.e.s #5448
Reasoning:
The build directory is cleared anyway before each builds and is available in
sourcesalready so keeping it around doesn't have any purpose and only wastes precious disk space.