Fix Windows builds with OCaml >= 5.0#6189
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Sep 13, 2024
Merged
Conversation
db827a9 to
f9a8b30
Compare
kit-ty-kate
commented
Sep 4, 2024
f9a8b30 to
65d89bb
Compare
Member
Author
|
OCaml 5.3 support requires a new release of extlib first actually (see ygrek/ocaml-extlib#73) |
65d89bb to
858239d
Compare
Member
Author
|
I split the Github action part in #6192 to be merged later |
858239d to
d67dced
Compare
dra27
approved these changes
Sep 13, 2024
Member
dra27
left a comment
There was a problem hiding this comment.
copy# means that in the unlikely event of a syntax error, Dune continues to report the correct source file. I have a suggestion in dra27@0608ec5 which eliminates the code duplication between the two OCaml files, but I'm not sure it's necessarily better, given that the file changes very rarely.
9805140 to
d35170c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6148