Skip to content

Add support for OCaml 5.3#73

Merged
ygrek merged 1 commit intoygrek:masterfrom
kit-ty-kate:ocaml-5.3
Sep 12, 2024
Merged

Add support for OCaml 5.3#73
ygrek merged 1 commit intoygrek:masterfrom
kit-ty-kate:ocaml-5.3

Conversation

@kit-ty-kate
Copy link
Copy Markdown
Contributor

Changed in ocaml/ocaml#13003

#=== ERROR while compiling extlib.1.7.9 =======================================#
# context              2.2.0~beta3~dev | linux/x86_64 | ocaml-variants.5.3.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.3/.opam-switch/build/extlib.1.7.9
# command              ~/.opam/5.3/bin/dune build -p extlib -j 1
# exit-code            1
# env-file             ~/.opam/log/extlib-20-35b0de.env
# output-file          ~/.opam/log/extlib-20-35b0de.out
### output ###
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlc.opt -w -40 -w -3-6-9-27-32-33-35-39-50 -g -bin-annot -I src/.extlib.objs/byte -intf-suffix .ml -no-alias-deps -o src/.extlib.objs/byte/extArray.cmo -c -impl src/extArray.pp.ml)
# File "src/extArray.pp.ml", line 1:
# Error: The implementation "src/extArray.pp.ml"
#        does not match the interface "src/extArray.pp.ml":  ... In module "Array":
#        Values do not match:
#          external create_float : int -> float array
#            = "caml_array_create_float"
#        is not included in
#          external create_float : int -> float array = "caml_make_float_vect"
#        The names of the primitives are not the same
#        File "src/extArray.mli", line 116, characters 2-69:
#          Expected declaration
#        File "array.mli", line 66, characters 0-69: Actual declaration
# (cd _build/default && /home/opam/.opam/5.3/bin/ocamlopt.opt -w -40 -w -3-6-9-27-32-33-35-39-50 -g -I src/.extlib.objs/byte -I src/.extlib.objs/native -intf-suffix .ml -no-alias-deps -o src/.extlib.objs/native/extArray.cmx -c -impl src/extArray.pp.ml)
# File "src/extArray.pp.ml", line 1:
# Error: The implementation "src/extArray.pp.ml"
#        does not match the interface "src/extArray.pp.ml":  ... In module "Array":
#        Values do not match:
#          external create_float : int -> float array
#            = "caml_array_create_float"
#        is not included in
#          external create_float : int -> float array = "caml_make_float_vect"
#        The names of the primitives are not the same
#        File "src/extArray.mli", line 116, characters 2-69:
#          Expected declaration
#        File "array.mli", line 66, characters 0-69: Actual declaration

@kit-ty-kate
Copy link
Copy Markdown
Contributor Author

cc @ygrek would you be able to have a look at it? This is required for opam to be compatible with the upcoming OCaml 5.3

Copy link
Copy Markdown
Collaborator

@MisterDA MisterDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this fixes the build with OCaml 5.3.

@ygrek ygrek merged commit 70906ef into ygrek:master Sep 12, 2024
@kit-ty-kate
Copy link
Copy Markdown
Contributor Author

Thank you so much! Would it be possible to have a release whenever you have some spare time?

@ygrek
Copy link
Copy Markdown
Owner

ygrek commented Sep 18, 2024

@kit-ty-kate
Copy link
Copy Markdown
Contributor Author

Thanks! I've opened a PR against opam-repository: ocaml/opam-repository#26584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants