Skip to content

GHA: Add OCaml 5.3 to the build matrix#6192

Merged
kit-ty-kate merged 3 commits intoocaml:masterfrom
kit-ty-kate:gha-ocaml-5.3
Jan 23, 2025
Merged

GHA: Add OCaml 5.3 to the build matrix#6192
kit-ty-kate merged 3 commits intoocaml:masterfrom
kit-ty-kate:gha-ocaml-5.3

Conversation

@kit-ty-kate
Copy link
Copy Markdown
Member

@kit-ty-kate kit-ty-kate commented Sep 5, 2024

Split off from #6189 as OCaml 5.3 is not released yet and contains several issues such as incompatibility with C++ (ocaml/ocaml#13422) and Cygwin (ocaml/ocaml#13421)

@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Sep 5, 2024
@kit-ty-kate kit-ty-kate mentioned this pull request Sep 5, 2024
Merged
@dra27
Copy link
Copy Markdown
Member

dra27 commented Sep 10, 2024

Why are we dropping i686 builds completely? I can't remember - do the Linux builds use opam to create the compiler switches, or did we optimise it with a system compiler?

This was referenced Sep 25, 2024
Closed
Merged
@kit-ty-kate kit-ty-kate changed the title GHA: Use both 4.14 and 5.3 as default version, remove i686 from the build matrix and add 5.2 GHA: Add OCaml 5.3 to the build matrix Oct 10, 2024
@kit-ty-kate kit-ty-kate marked this pull request as ready for review January 8, 2025 22:57
@kit-ty-kate
Copy link
Copy Markdown
Member Author

kit-ty-kate commented Jan 9, 2025

@dra27 @MisterDA do you have an idea what's wrong with the cygwin port with 5.3.0?

  ** Cannot resolve symbols for descriptor object:
   _ZTH10caml_state
  File "caml_startup", line 1:
  Error: Error during linking (exit code 2)

@kit-ty-kate
Copy link
Copy Markdown
Member Author

kit-ty-kate commented Jan 9, 2025

ocaml/ocaml#13591 was supposed to fix this issue (ocaml/ocaml#13541) but it doesn't look like it did

@kit-ty-kate
Copy link
Copy Markdown
Member Author

kit-ty-kate commented Jan 9, 2025

cc @NickBarnes as well just in case since you also reviewed that PR

@kit-ty-kate kit-ty-kate requested a review from dra27 January 9, 2025 15:02
@kit-ty-kate kit-ty-kate force-pushed the gha-ocaml-5.3 branch 2 times, most recently from aad580b to ade79af Compare January 22, 2025 21:42
@kit-ty-kate
Copy link
Copy Markdown
Member Author

kit-ty-kate commented Jan 22, 2025

C++ support is indeed broken on Cygwin (see mention in MisterDA/ocaml#118). I've disabled it temporarily while this is being debugged and fixed upstream (hopefully in a future 5.3.1 release).

In the meantime this is ready to review and merge

dra27
dra27 reviewed Jan 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just may as well bump to 5.2.1 while transferring it to the "library tests" bit

@kit-ty-kate kit-ty-kate merged commit 6dacaa8 into ocaml:master Jan 23, 2025
@kit-ty-kate kit-ty-kate deleted the gha-ocaml-5.3 branch January 23, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dra27 dra27 dra27 left review comments

@rjbou rjbou rjbou approved these changes

Assignees

No one assigned

Labels

AREA: BUILD AREA: PORTABILITY AREA: TEST

Projects

None yet

Milestone

2.4.0~alpha1

Development

Successfully merging this pull request may close these issues.

3 participants

@kit-ty-kate @dra27 @rjbou