Skip to content

opamClient: pass dl_cache from initConfig to config#5315

Merged
rjbou merged 4 commits intoocaml:masterfrom
hannesm:pass-dl-cache
Oct 25, 2022
Merged

opamClient: pass dl_cache from initConfig to config#5315
rjbou merged 4 commits intoocaml:masterfrom
hannesm:pass-dl-cache

Conversation

@hannesm
Copy link
Copy Markdown
Member

@hannesm hannesm commented Oct 14, 2022

Previously, the dl_cache from the InitConfig was never used.

@hannesm
Copy link
Copy Markdown
Member Author

hannesm commented Oct 16, 2022

fixes #5316

@kit-ty-kate kit-ty-kate changed the title opamClient: pass dl_cache from initConfig to config Make archive-mirrors modifiable via opam config Oct 17, 2022
@rjbou rjbou self-requested a review October 17, 2022 12:33
@rjbou rjbou changed the title Make archive-mirrors modifiable via opam config opamClient: pass dl_cache from initConfig to config Oct 17, 2022
@rjbou
Copy link
Copy Markdown
Collaborator

rjbou commented Oct 17, 2022

We changed the title by mistake, first commit went unnoticed, which lead to the change. Can you open a different PR for making archive-mirrors modifiable?
For this one (dl_cache/init_config), i'll see to add a test for that in the PR.

@hannesm
Copy link
Copy Markdown
Member Author

hannesm commented Oct 18, 2022

Hello,

sorry about putting two things into a single PR. I force-pushed here (and the title reflects the change). #5321 is the other change (that previously was part of this PR).

@rjbou rjbou added PR: QUEUED Pending pull request, waiting for other work to be merged or closed and removed PR: NEEDS UPDATE labels Oct 19, 2022
@rjbou rjbou requested a review from kit-ty-kate October 19, 2022 17:58
@rjbou rjbou added PR: WAITING FOR REVIEW and removed PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Oct 19, 2022
@rjbou
Copy link
Copy Markdown
Collaborator

rjbou commented Oct 19, 2022

Added a test for opamrc handling

@hannesm
Copy link
Copy Markdown
Member Author

hannesm commented Oct 21, 2022

Thanks @rjbou, to me this looks ready to be merged.

@rjbou rjbou merged commit 502ba8c into ocaml:master Oct 25, 2022
@rjbou
Copy link
Copy Markdown
Collaborator

rjbou commented Oct 25, 2022

thanks!

@rjbou rjbou mentioned this pull request Feb 15, 2023
kit-ty-kate pushed a commit to kit-ty-kate/opam that referenced this pull request Feb 17, 2023
opamClient: pass dl_cache from initConfig to config
rjbou added a commit to kit-ty-kate/opam that referenced this pull request May 12, 2023
opamClient: pass dl_cache from initConfig to config
@rjbou rjbou modified the milestones: 2.2.0~alpha, 2.1.5 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants