Revert #2307 ( Hint on type error on numeric operators )#8827
Merged
Octachron merged 4 commits intoocaml:4.09from Aug 12, 2019
Merged
Revert #2307 ( Hint on type error on numeric operators )#8827Octachron merged 4 commits intoocaml:4.09from
Octachron merged 4 commits intoocaml:4.09from
Conversation
Octachron
reviewed
Jul 31, 2019
This partially reverts commit 0bc5b71.
b0d5f29 to
abb0523
Compare
Octachron
reviewed
Aug 1, 2019
abb0523 to
afc20b4
Compare
Member
Author
|
Indeed, fixed.
…On Thu, Aug 1, 2019 at 5:38 PM Florian Angeletti ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tools/caml_tex.ml
<#8827 (comment)>:
> pp_submsg_loc = (fun _ _ _ loc -> register_loc loc);
+
+ (* The following fields are kept identical to [p] but explicit
Was base first named p?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8827?email_source=notifications&email_token=AADIB7WXAZODFHLBZP4GDRTQCL7QBA5CNFSM4IGRVWQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCAJWWXI#pullrequestreview-269708125>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADIB7VQYQCDVF3NXWP2G2DQCL7QBANCNFSM4IGRVWQQ>
.
|
(following presentation advice from Florian Angeletti)
Member
Author
|
@Octachron: if/when you approve of the PR, please feel free to merge. |
Member
|
Ok, I shall review a little more cautiously on Monday and then merge. |
Member
|
Cherry-picked on trunk as c56ed41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As announced in #2307 (comment), there is no consensus for the in-compiler implementatoin of #2307, and the maintainers thus decided that it was best to revert the change for now.
This PR is a manual revert of #2307, keeping the refactoring commits and avoiding conflicts with the later refactorings of #2313, removing only the core logic for type errors on numeric operators.
It is targeted for 4.09 (we want to revert before the feature is released!), but I plan to cherry-pick to trunk afterwards.