Conversation
|
You don't need to change |
|
@Armael I reverted and use |
|
@Armael I finally reverted all my changes to |
Armael
left a comment
There was a problem hiding this comment.
Sorry for the delay on reviewing this. The patch looks good, I agree it's an improvement.
I left a couple comments, but I'm ready to merge after they are addressed.
|
Thanks for the review ! #2319 may not be merged because my PRs are adding code that should not be in the type checker. Do you think moving error-reporting code to another module is feasible or is a good solution ? |
|
Let's not mix this PR and #2319 . And note that in the current situation, creating new modules in the compiler is a bit delicate, since they pollute the global namespace for anyone linking against compiler-libs... |
As @gasche pointed out on my previous PR, my two previous PR need a small cleanup.
I changed
Location.reportto allow sub messages without location and print the int literal hint as a sub message.