Skip to content

Add --profinfo XX to ./configure#735

Merged
lefessan merged 1 commit intoocaml:trunkfrom
lefessan:2016-08-02-with-prof-id
Sep 5, 2016
Merged

Add --profinfo XX to ./configure#735
lefessan merged 1 commit intoocaml:trunkfrom
lefessan:2016-08-02-with-prof-id

Conversation

@lefessan
Copy link
Copy Markdown
Contributor

@lefessan lefessan commented Aug 2, 2016

Support for adding profinfo in headers is added by Spacetime. This commit
generalizes that support by providing this feature without Spacetime.
You can now specify "./configure --profinfo 22" for example to tell OCaml that you want the last 22 bits of the header (on 64 bits) to be preserved to store block profiling information.

@lefessan
Copy link
Copy Markdown
Contributor Author

lefessan commented Aug 2, 2016

The patch also contains some fixes on Spacetime:

  • {asmrun|byterun}/spacetime.h are converted to a single file in caml/spacetime.h
  • PROFINFO_WIDTH is used in mlvalues.h in a place where its previous value (26) was hardcoded

@mshinwell
Copy link
Copy Markdown
Contributor

Maybe --profinfo-bits for the configure option would be more descriptive?

Could you please split the patch for the fix to the hard-coded value in mlvalues.h into a separate pull request against the 4.04 branch? That was an oversight, and we should fix it there.

@mshinwell mshinwell changed the title (WIP) Add --profinfo XX to ./configure Add --profinfo XX to ./configure Aug 3, 2016
@alainfrisch
Copy link
Copy Markdown
Contributor

I like the feature, but not the name. If I understand correctly, this is about reserving bits from the header words, for whatever purpose one can imagine. This could be used for debugging (e.g. tracing where a value has been created) as well as profiling, for instance; and possibly for other purposes.

What about -reserved-header-bits?

@lefessan lefessan force-pushed the 2016-08-02-with-prof-id branch 2 times, most recently from 2dd399a to 9147f2d Compare August 29, 2016 14:55
@lefessan
Copy link
Copy Markdown
Contributor Author

I followed @alainfrisch naming advice for the option in configure, but it is still called profinfo internally, following the initial name from Spacetime. I am not sure it is worth also changing the name internally.

Maybe we can merge, and change the name later if really important.

@lefessan lefessan force-pushed the 2016-08-02-with-prof-id branch from 9147f2d to 6b436a4 Compare August 29, 2016 20:28
with XX a number smaller than 32 (to leave at least 22 bits for the size)
@lefessan lefessan merged commit 632ad93 into ocaml:trunk Sep 5, 2016
@lefessan
Copy link
Copy Markdown
Contributor Author

lefessan commented Sep 5, 2016

Looks like we have no opposition to the latest version, so merging.

@lefessan lefessan deleted the 2016-08-02-with-prof-id branch September 5, 2016 13:46
@lpw25 lpw25 mentioned this pull request Oct 6, 2017
camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017
Add --reserved-header-bits XX to ./configure
EduardoRFS pushed a commit to esy-ocaml/ocaml that referenced this pull request Dec 17, 2021
add caml_young_alloc_start and caml_young_alloc_end in minor_gc.c
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Sep 21, 2022
stedolan pushed a commit to stedolan/ocaml that referenced this pull request Sep 21, 2022
ce76e02 flambda-backend: Bugfix for type_application (ocaml#746)
44f3afb flambda-backend: PR580 for main branch (ocaml#743)
b851eaa flambda-backend: Backport first part of ocaml/ocaml PR10498 (ocaml#737)
fafb4bd flambda-backend: Fix return mode for eta-expanded function in type_argument (ocaml#735)
c31f6c3 flambda-backend: Fix treatment of functions called [@nontail] (ocaml#725)
847781e flambda-backend: Fix build_upstream post-PR703 (ocaml#712)
bfcbbf8 flambda-backend: Extend Pblock value kind to handle variants (ocaml#703)
b2cab95 flambda-backend: Merge ocaml-jst
a6d6e0e flambda-backend: Merge ocaml-jst
88a4f63 flambda-backend: Use Pmakearray for immutable arrays (ocaml#699)
eeaa44b flambda-backend: Install an ocamldoc binary (ocaml#695)
48d322b flambda-backend: Ensure that GC is not invoked from bounds check failures (ocaml#681)
4370fa1 flambda-backend: Review changes of term directory (ocaml#602)
65a4566 flambda-backend: Add code coverage using bisect_ppx (ocaml#352)
63ab65f flambda-backend: Bugfix for primitive inclusion (ocaml#662)
7e3e0c8 flambda-backend: Fix inclusion checks for primitives (ocaml#661)
96c68f9 flambda-backend: Speed up linking by changing cmxa format (ocaml#607)
1829150 flambda-backend: Bugfix for Translmod.all_idents (ocaml#659)

git-subtree-dir: ocaml
git-subtree-split: ce76e02
sadiqj pushed a commit to sadiqj/ocaml that referenced this pull request Feb 21, 2023
EmileTrotignon pushed a commit to EmileTrotignon/ocaml that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants