Conversation
[caml_modify_generational_global_root] makes it possible for an old root to be in the young generation, but [caml_remove_generational_global_root] did not take this into account.
|
Would you please describe the bug in question? |
|
Pardon me or the lack of detail:
|
|
More precisely, a comment in [caml_modify_generational_global_root] says : "It is OK to have a root in roots_young that suddenly points to the old generation". But this is not correct for root removal. |
|
Why do you change also Le jeu. 9 juin 2016 13:18, Jacques-Henri Jourdan notifications@github.com
|
|
This part of caml_modify_generational_global_root is executed whenever the root becomes unboxed. In this case, we want to delete the root. Hence, the code needs to do the same thing as |
|
I cliked the tempting "merge" button but the change went in the @damiendoligez , should we put bugfixes in 4.03? Is there a 4.03.1 planned? |
|
Sorry, 4.03 was the branch I was working on, so I did a patch on it, thinking you would backport it anyway... But indeed, if there is no 4.03.1 planned, this is silly. |
|
I will merge the 4.03 branch into trunk very soon and close it. There will not be a 4.03.1 release. |
ce76e02 flambda-backend: Bugfix for type_application (ocaml#746) 44f3afb flambda-backend: PR580 for main branch (ocaml#743) b851eaa flambda-backend: Backport first part of ocaml/ocaml PR10498 (ocaml#737) fafb4bd flambda-backend: Fix return mode for eta-expanded function in type_argument (ocaml#735) c31f6c3 flambda-backend: Fix treatment of functions called [@nontail] (ocaml#725) 847781e flambda-backend: Fix build_upstream post-PR703 (ocaml#712) bfcbbf8 flambda-backend: Extend Pblock value kind to handle variants (ocaml#703) b2cab95 flambda-backend: Merge ocaml-jst a6d6e0e flambda-backend: Merge ocaml-jst 88a4f63 flambda-backend: Use Pmakearray for immutable arrays (ocaml#699) eeaa44b flambda-backend: Install an ocamldoc binary (ocaml#695) 48d322b flambda-backend: Ensure that GC is not invoked from bounds check failures (ocaml#681) 4370fa1 flambda-backend: Review changes of term directory (ocaml#602) 65a4566 flambda-backend: Add code coverage using bisect_ppx (ocaml#352) 63ab65f flambda-backend: Bugfix for primitive inclusion (ocaml#662) 7e3e0c8 flambda-backend: Fix inclusion checks for primitives (ocaml#661) 96c68f9 flambda-backend: Speed up linking by changing cmxa format (ocaml#607) 1829150 flambda-backend: Bugfix for Translmod.all_idents (ocaml#659) git-subtree-dir: ocaml git-subtree-split: ce76e02
* Turn hash into an optional parameter
* Define helper function with_hash, allowing to deal with
optional hash parameter in applicable functions
* Add hash as optional parameter in functions:
+ package,
+ package_with_version
+ package_doc
* Remove corresponding with_{hash|univ} functions (in order):
+ package_with_univ
+ package_with_hash_with_version
+ package_doc_with_hash
This commit corrects a bug in the code for generational roots:
[caml_modify_generational_global_root] makes it possible for an old
root to be in the young generation, but [caml_remove_generational_global_root]
did not take this into account.
The bug probably also exists in all recent branches.