Minor prettify printing of tuple types and constructor declaration#485
Merged
damiendoligez merged 1 commit intoocaml:trunkfrom Feb 25, 2016
Merged
Minor prettify printing of tuple types and constructor declaration#485damiendoligez merged 1 commit intoocaml:trunkfrom
damiendoligez merged 1 commit intoocaml:trunkfrom
Conversation
Member
|
Thanks for the patch. |
damiendoligez
added a commit
that referenced
this pull request
Feb 25, 2016
Minor prettify printing of tuple types and constructor declaration
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 30, 2021
PR ocaml#470 propagates substitutions down into lambdas, which works when the RHS is a constant or symbol but not if it's a variable, since that variable is now out of scope. This was breaking ocaml#485, which produces variable-for-variable substitutions often. Fortunately, variable-for-variable substitution under a lambda is also unnecessary (we already dealt with the free occurrences by making a closure element), so we can happily just filter out any such bindings.
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 30, 2021
PR ocaml#470 propagates substitutions down into lambdas, which works when the RHS is a constant or symbol but not if it's a variable, since that variable is now out of scope. This was breaking ocaml#485, which produces variable-for-variable substitutions often. Fortunately, variable-for-variable substitution under a lambda is also unnecessary (we already dealt with the free occurrences by making a closure element), so we can happily just filter out any such bindings.
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 30, 2021
…#514) PR ocaml#470 propagates substitutions down into lambdas, which works when the RHS is a constant or symbol but not if it's a variable, since that variable is now out of scope. This was breaking ocaml#485, which produces variable-for-variable substitutions often. Fortunately, variable-for-variable substitution under a lambda is also unnecessary (we already dealt with the free occurrences by making a closure element), so we can happily just filter out any such bindings.
lukemaurer
added a commit
to lukemaurer/ocaml
that referenced
this pull request
Jul 7, 2021
This includes ocaml#485.
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jul 13, 2021
chambart
pushed a commit
to chambart/ocaml-1
that referenced
this pull request
Feb 1, 2022
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
Co-authored-by: tmattio <tmattio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an extra whitespace before
*while printing tuple types and constructor declarations throughdsource. The following file:is printed as:
and with the fix is printed as: