Merged
Conversation
This summarizes Xavier's recommendations at ocaml#342 (comment) which were later reused at ocaml#307 (comment) In particular this should create a URL anchor to direct people to: https://github.com/ocaml/ocaml/blob/trunk/CONTRIBUTING.md#how-to-sign-the-cla
Member
Author
|
You can see the rendered result at |
Contributor
|
You should probably rephrase a bit the phrase
I didn't find any good phrasing yet, but we probably also want to mention that this also allow the license to evolve, like the recent change to LGPL which wouldn't have been possible since the copyright owners of some contributions are probably very hard to find and reach. |
Member
Author
|
I don't plan to do the change @chambart proposed myself. I like the current phrasing and am not particularly into CLA apologetics. (Also I feel ambivalent about saying "see CLA is good as we can easily change to better licences" given that OCaml used for decades the license that I personally like least of all possible free software licenses, unrelatedly to the existence of the CLA. Not really a great demonstration.) |
gasche
added a commit
that referenced
this pull request
Feb 19, 2016
CONTRIBUTING: how to sign the CLA
Member
Author
|
(I decided to go ahead and merge this low-risk, nobody-cares change.) |
EduardoRFS
pushed a commit
to esy-ocaml/ocaml
that referenced
this pull request
May 17, 2021
Systhreads: Current_thread->next value should be saved before setting it to Current_thread after freeing the thread decriptor.
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 25, 2021
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 30, 2021
PR ocaml#470 propagates substitutions down into lambdas, which works when the RHS is a constant or symbol but not if it's a variable, since that variable is now out of scope. This was breaking ocaml#485, which produces variable-for-variable substitutions often. Fortunately, variable-for-variable substitution under a lambda is also unnecessary (we already dealt with the free occurrences by making a closure element), so we can happily just filter out any such bindings.
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 30, 2021
PR ocaml#470 propagates substitutions down into lambdas, which works when the RHS is a constant or symbol but not if it's a variable, since that variable is now out of scope. This was breaking ocaml#485, which produces variable-for-variable substitutions often. Fortunately, variable-for-variable substitution under a lambda is also unnecessary (we already dealt with the free occurrences by making a closure element), so we can happily just filter out any such bindings.
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 30, 2021
…#514) PR ocaml#470 propagates substitutions down into lambdas, which works when the RHS is a constant or symbol but not if it's a variable, since that variable is now out of scope. This was breaking ocaml#485, which produces variable-for-variable substitutions often. Fortunately, variable-for-variable substitution under a lambda is also unnecessary (we already dealt with the free occurrences by making a closure element), so we can happily just filter out any such bindings.
mshinwell
pushed a commit
to mshinwell/ocaml
that referenced
this pull request
Jun 30, 2021
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
…ml#470) * In the `Cfg.basic_block` type, change the `exns : Label.Set.t` field to `exn : Label.t option`. * Update backend/cfg/linear_to_cfg.ml Co-authored-by: Greta Yorsh <45005955+gretay-js@users.noreply.github.com> * Simplify linear_to_cfg a bit more * Format * Simplify `Cfgize`. * Review. * Format. * Fix Co-authored-by: Greta Yorsh <45005955+gretay-js@users.noreply.github.com> Co-authored-by: Greta Yorsh <gyorsh@janestreet.com>
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
* use 4.14.0 as latest ocaml version To get up and running it's confusion if an older version is shown. I've also added an instruction to show all possible switches but as that returns a huge list, I'm wondering if that might be too much for the up and running. On the other hand, it would be good for new people to find a list of possible releases they can use. see for example this question: https://discuss.ocaml.org/t/are-ocaml-install-instructions-up-to-date/9941
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This summarizes Xavier's recommendations at
#342 (comment)
which were later reused at
#307 (comment)
In particular this should create a URL anchor to direct people to:
https://github.com/ocaml/ocaml/blob/trunk/CONTRIBUTING.md#how-to-sign-the-cla