parmatch.ml refactoring: make the simplify_head_pat functions more generic#1577
Merged
gasche merged 1 commit intoocaml:trunkfrom Jan 23, 2018
Merged
parmatch.ml refactoring: make the simplify_head_pat functions more generic#1577gasche merged 1 commit intoocaml:trunkfrom
gasche merged 1 commit intoocaml:trunkfrom
Conversation
rajgodse
added a commit
to rajgodse/ocaml
that referenced
this pull request
Aug 18, 2023
* allows pattern guard with no value clauses * add e2e tests for only exception patterns * rename and comment typecore changes * add tests for empty variant * clean tests after rebase on origin/pattern-guards * update comments around require_value_case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second take on #1561 -- without the module-structure part that justified the previous PR, so I decided to create new PR.
cc @trefis