Conversation
|
This change is best reviewed while ignoring whitespace: |
trefis
left a comment
There was a problem hiding this comment.
Thanks.
Let's wait for the other PR to be merged before taking any action?
Changes
Outdated
| ### Internal/compiler-libs changes: | ||
|
|
||
| - GPR#1488: Refreshing parmatch | ||
| - GPR#1488, GPR#1561: Refreshing parmatch |
There was a problem hiding this comment.
I wouldn't add that here.
I would add it to your other GPR which started changing the names. (so yes, I would wait for the other to be merged and then rebase this PR, if I were you)
typing/parmatch.ml
Outdated
| *) | ||
|
|
||
| let rec every_satisfiables pss qs = match qs.active with | ||
| let rec every_satisfiables pss qs = let open Usefulness in match qs.active with |
There was a problem hiding this comment.
I generally try to avoid changing the indentation level from a patch, but here we can change it if we review with whitespace ignored anyway.
My idea (in making a separate PR) was rather that this one could be merged relatively quickly (that is, if we agree), whereas #1552 was awaiting an extra review for correctness. So I planned to rebase #1552 on top of the present one. But if you prefer to wait, well we can always wait :-) |
df246fc to
4f7aab1
Compare
|
I changed and rebased the patchset according to @trefis comments. |
c3f8e7a to
c79b5e7
Compare
25e2a42 to
25e5794
Compare
The need for this change arose while working on ambigous variables: sometimes you may want to refer to two different `simplify_first_col` functions, if you manipulate two kind of rows at once -- typically, negative and positive rows need not carry the same metadata.
|
(I also had to rebase on top of #1560 which introduced minor conflicts) |
|
I finally had a look and discussed this offline with gasche and the conclusion is that we're going to merge some version of the second patch (i.e. the refactoring making |
|
Closing this in favour of #1577. |
cc @trefis
This change was suggested by @trefis during the review of #1552.
Sometimes we may want to refer to two different
simplify_first_colfunctions, if you manipulate two kind of rows at once -- typically,
negative and positive rows need not carry the same metadata.