Restore SYSTEM, ARCH and MODEL information for bytecode-only architectures#11639
Merged
dra27 merged 1 commit intoocaml:trunkfrom Oct 18, 2022
Merged
Restore SYSTEM, ARCH and MODEL information for bytecode-only architectures#11639dra27 merged 1 commit intoocaml:trunkfrom
SYSTEM, ARCH and MODEL information for bytecode-only architectures#11639dra27 merged 1 commit intoocaml:trunkfrom
Conversation
Member
Author
|
Running through precheck#791 |
shindere
approved these changes
Oct 18, 2022
Contributor
|
The diff is not trivial to read IMO but I do think the change is correct
and should be merged as soon as possible.
|
Member
Author
|
Thanks, @shindere! |
dra27
added a commit
that referenced
this pull request
Oct 18, 2022
Restore `SYSTEM`, `ARCH` and `MODEL` information for bytecode-only architectures (cherry picked from commit 6a8bb4e)
Member
Author
|
Pushed to 5.0 in 76d6bae along with @Octachron's fix for Jenkins in 3411237 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mechanism used to mark the "no native backend yet" configurations for OCaml 5.0 in #10871 accidentally reverts #10044 (and which I just noticed while trying to use the value of
systemon a bytecode-only architecture).This affects/regresses the output of
ocamlc -configon the affected architectures, so I think it ought to go on 5.0.