Always set SYSTEM, ARCH and MODEL#10044
Conversation
ae4b021 to
2fbf4fe
Compare
|
For this PR, I am certain that we should always report The argument is less clear for |
xavierleroy
left a comment
There was a problem hiding this comment.
Makes sense to me. Besides, it only makes a difference with the --disable-native-compiler configure option, which is rarely used as far as I can imagine.
|
I'll let @dra27 and @Octachron decide whether to cherry-pick to 4.12. |
|
Thanks, @xavierleroy! It receives occasional use by me (which is how I discovered it) since I think we still don't have a way to tell Just for the proverbial record, we do ship a Entirely up to @Octachron where 4.12 is concerned. |
|
A configuration fix seems fine for 4.12 . |
Even if --disable-native-compiler is given. (cherry picked from commit 42efb99)
|
If this is cherry-picked to 4.12, #10074 must be cherry-picked also. |
Even if --disable-native-compiler is given.
On second though, the "surprising" behavior was the correct one, given that |
|
Just for the proverbial record, though, the test has never been a (portably) reliable test for ocamlopt: the Windows Lines 70 to 77 in aad3b34 |
|
Actually, that argument is a bit specious for those manual |
While looking at something else, I encountered a subtle compilation fault in win32unix:
ocaml/otherlibs/win32unix/Makefile
Line 57 in a93a564
Before 4.08 and autoconf,
config/Makefile.mingwalways setSYSTEM:ocaml/config/Makefile.mingw
Line 77 in aad3b34
so this worked. However, when we switched to autoconf, the build system adopted the usual
ARCH=none,MODEL=default,SYSTEM=unknownif you configure without the native compiler.This PR tentatively stops resetting
ARCH,MODEL, andSYSTEM. The only place I could quickly see where these are used instead of the newerNATIVE_COMPILER=truevariable inMakefile.configwas thechecknativetarget.This has been wrong for a while, so there's no rush for 4.12