Restore helpful error message when make is run before configure (#11347 revisited)#11352
Merged
dra27 merged 2 commits intoocaml:trunkfrom Jun 24, 2022
Merged
Conversation
Let configure decide whether make should make world.opt or world, depending on whether the native compiler has been enabled or not.
Make sure stdlib/StdlibModules depends on sak only if the tree has been configured. If the tree has not been configured this dependency is useless.
Contributor
Author
|
As a bonus, this PR's first commit moves the computation of the default |
dra27
approved these changes
Jun 24, 2022
Member
dra27
left a comment
There was a problem hiding this comment.
This is a better approach than mine, thanks!
Contributor
Author
|
David Allsopp (2022/06/24 00:47 -0700):
Merged #11352 into trunk.
Thanks a lot!
|
Contributor
Author
|
David Allsopp (2022/06/24 00:47 -0700):
@dra27 approved this pull request.
This is a better approach than mine, thanks!
Thanks for your review and positive feedback!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title suggests, this is an alternative proposal to #11347.
The idea is to "hide" a dependency rule that prevents our error message
from being displayed if the tree has not been configured.
It feels a pity though that we have to use such tricks, but I couldn't
find a better way at the moment.
I like this better than #11347 because, to solve the problem, it
removes a dependency, rather than adding an (IMO) not-so-legitimate one.