Skip to content

Restore helpful error message when make is run before configure#11347

Closed
dra27 wants to merge 1 commit intoocaml:trunkfrom
dra27:make-error
Closed

Restore helpful error message when make is run before configure#11347
dra27 wants to merge 1 commit intoocaml:trunkfrom
dra27:make-error

Conversation

@dra27
Copy link
Copy Markdown
Member

@dra27 dra27 commented Jun 22, 2022

Prior to 4.13, running make in an empty tree displayed a helpful error message:

Please refer to the installation instructions:
- In file INSTALL for Unix systems.
- In file README.win32.adoc for Windows systems.
On Unix systems, if you've just unpacked the distribution,
something like
        ./configure
        make
        make install
should work.
Makefile.config_if_required:29: Makefile.build_config: No such file or directory
make: *** [Makefile:1095: config.status] Error 1

Since 4.13, an alternate, much less helpful, error has been displayed. This PR restores the error message by adding the missing dependency on config.status to the generation rule for runtime/sak.$(O).

@shindere
Copy link
Copy Markdown
Contributor

shindere commented Jun 23, 2022 via email

dra27 added a commit that referenced this pull request Jun 24, 2022
…or-message

Restore helpful error message when make is run before configure (#11347 revisited)
@dra27
Copy link
Copy Markdown
Member Author

dra27 commented Jun 24, 2022

This dependency of stdlib/StdlibModules is written and documented in Makefile.common but I don't understand why exactly we need it?

The root Makefile includes stdlib/StdlibModules and sak is needed to build it. The dependency at present is there to ensure that any inclusion of stdlib/StdlibModules definitely builds sak first (the documentation Makefiles also use it IIRC). I expect this is something that becomes much cleaner when all the Makefiles are merged - the problem at the moment (or at least, as on the 4.14 branch) is that runtime/Makefile is responsible for building sak but it's then used in lots of other Makefiles

@dra27
Copy link
Copy Markdown
Member Author

dra27 commented Jun 24, 2022

Closing in favour of #11352, which is a cleaner approach!

@dra27 dra27 closed this Jun 24, 2022
@dra27 dra27 deleted the make-error branch June 24, 2022 07:50
@shindere
Copy link
Copy Markdown
Contributor

shindere commented Jun 27, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants