Merged
Conversation
Member
Member
|
Remove the header completely, or just make it a no-op? |
Contributor
Remove. The existence of |
xavierleroy
approved these changes
Jan 10, 2022
xavierleroy
reviewed
Jan 10, 2022
34 tasks
artempyanykh
added a commit
to artempyanykh/infer
that referenced
this pull request
Oct 9, 2022
Summary: This is an MVP to make Infer build with ocaml 5.0.0~alpha1 It does require a bit of a setup, in particular: 1. opam repo add alpha git+https://github.com/kit-ty-kate/opam-alpha-repository.git 2. `opam pin add` for [javalib](javalib-team/javalib#22) and [sawja](javalib-team/sawja#8). parmap is not compatible with multi-core and I'm not sure it'll be compatible anytime soon because of [compatibility.h deprecation](ocaml/ocaml#10863). However, we use only `Setcore` from parmap; some of those functions should have an alternative in Stdlib.Domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #10831, this PR gets rid of
caml/compatibility.h.