Use Stdlib instead of Pervasives#8
Merged
davidpichardie merged 2 commits intojavalib-team:masterfrom Dec 13, 2022
Merged
Conversation
Pervasives was deprecated in favor of directly using Stdlib in 4.08 and then removed in the upcoming 5.0. This change makes javalib buildable with the multi-core ocaml 5.0~alpha. NOTE: I checked that the project builds with 5.0 but I didn't try to run anything. In particular I'm not sure what jvmti native stubs do.
artempyanykh
added a commit
to artempyanykh/infer
that referenced
this pull request
Oct 9, 2022
Summary: This is an MVP to make Infer build with ocaml 5.0.0~alpha1 It does require a bit of a setup, in particular: 1. opam repo add alpha git+https://github.com/kit-ty-kate/opam-alpha-repository.git 2. `opam pin add` for [javalib](javalib-team/javalib#22) and [sawja](javalib-team/sawja#8). parmap is not compatible with multi-core and I'm not sure it'll be compatible anytime soon because of [compatibility.h deprecation](ocaml/ocaml#10863). However, we use only `Setcore` from parmap; some of those functions should have an alternative in Stdlib.Domain.
davidpichardie
approved these changes
Dec 13, 2022
Contributor
|
Thanks a lot @artempyanykh! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pervasives was deprecated in favor of directly using Stdlib in 4.08 and then removed in the upcoming 5.0. This change makes javalib buildable with the multi-core ocaml 5.0~alpha.
NOTE: I checked that the project builds with 5.0 but I didn't try to run anything. In particular I'm not sure what jvmti native stubs do.
A companion javalib PR is javalib-team/javalib#22 (where the version is bumped to 3.2.2)