Fix exception when destructing an exception pattern in 410 + more flexible destruct >= 408#1169
Merged
voodoos merged 10 commits intoocaml:masterfrom Sep 10, 2020
Merged
Conversation
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Sep 16, 2020
CHANGES:
Wed Sep 16 15:00:42 CEST 2020
+ merlin binary
- fix completion of pattern matchings with exception patterns (ocaml/merlin#1169)
- delegate configuration reading to external programs via a simple protocol
and create a new package `dot-merlin-reader` with a binary that reads
`.merlin` files. (ocaml/merlin#1123, ocaml/merlin#1152)
rgrinberg
pushed a commit
to rgrinberg/merlin
that referenced
this pull request
Oct 6, 2020
…l#1169) * Filter or-patterns to remove exceptions * Only allow completion for exception patterns for ocaml < 4.11 * Update test suite * Always allow match completion for ocaml > 411
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destruct on exception pattern:
ocaml < 408408 <= ocaml < 411Does nothing forocaml >= 411Todo:
-log-fileparameters in tests