Add error messages for external configuration readers and disable quoting#1152
Merged
voodoos merged 6 commits intoocaml:masterfrom Sep 10, 2020
Merged
Add error messages for external configuration readers and disable quoting#1152voodoos merged 6 commits intoocaml:masterfrom
voodoos merged 6 commits intoocaml:masterfrom
Conversation
7b0bc3d to
8c52fe4
Compare
1eaa536 to
f09c8ef
Compare
5912582 to
c259798
Compare
798ce3f to
60e2a1f
Compare
60e2a1f to
7838f78
Compare
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Sep 16, 2020
CHANGES:
Wed Sep 16 15:00:42 CEST 2020
+ merlin binary
- fix completion of pattern matchings with exception patterns (ocaml/merlin#1169)
- delegate configuration reading to external programs via a simple protocol
and create a new package `dot-merlin-reader` with a binary that reads
`.merlin` files. (ocaml/merlin#1123, ocaml/merlin#1152)
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Nov 5, 2020
…ting (ocaml#1152) * Add more-precise error messages * Move rev from protocol to dot-merlin-reader * Move un-quoting work to dot-merlin-reader * Error if asking dune 2.6 for configuration * Change CHANGES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add better error reporting for the external readers.
Covered cases:
External reader unexpectedly not-running:
A problem occurred with merlin external configuration reader. Check that 'dot-merlin-reader' is installed. If the problem persists, please file an issue on Merlin's tracker.A problem occurred with merlin external configuration reader. Check that 'dune' is installed and up-to-date. If the problem persists, please file an issue on Merlin's tracker.Bad output from the external reader. That can happen if merlin tries to start
dune ocaml-merlinwith a version of dune that doesn't support this sub-command. Dune then prints it's help, which is not a valid csexp.Merlin could not load its configuration from the external reader. Building your project with 'dune' might solve this issue.This PR broke the tests: most of the tests do not have a
.merlinfile and the closest config file in parent directories was thedune-projectfile. This triggers aProject is not builtmessage from thedune ocaml-merlinconfig reader.To prevent that behaviour I added a dummy
merlinfile to thetest-dirsdirectory to trick merlin in usingdot-merlin-reader.