Fix inline_tests action when partition list is empty#8849
Merged
rgrinberg merged 2 commits intoocaml:mainfrom Oct 5, 2023
Merged
Fix inline_tests action when partition list is empty#8849rgrinberg merged 2 commits intoocaml:mainfrom
rgrinberg merged 2 commits intoocaml:mainfrom
Conversation
5c84f47 to
626704c
Compare
Alizter
reviewed
Oct 5, 2023
| |> Action.diff ~optional:true fn) | ||
| |> Action.concurrent | ||
| in | ||
| Action.Full.make ~sandbox @@ Action.progn [ run_tests; diffs ])) |
Collaborator
There was a problem hiding this comment.
Doesn't have to be in this PR, but wouldn't it make more sense to concurrently run and diff rather than concurrently run and then concurrently diff? At the moment, all the diffs have to wait for all the tests to run.
Collaborator
Author
There was a problem hiding this comment.
There is nothing allowing us to know what diff to perform after a given run
Alizter
approved these changes
Oct 5, 2023
Collaborator
Alizter
left a comment
There was a problem hiding this comment.
Fix looks good to me. Of course, we wouldn't need it if Action.Full.make was smart enough to avoid sandboxing if an action doesn't need it rather than complaining.
Member
|
Thanks. a CHANGES entry would be appropriate |
Collaborator
Author
done |
Member
|
DCO please :) |
86a8338 to
6cd402b
Compare
Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>
Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>
6cd402b to
35d821c
Compare
emillon
added a commit
that referenced
this pull request
Oct 9, 2023
* Parallel inline_tests: expose bug with empty partition list Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com> * Parallel inline_tests: Fix when partition list is empty Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com> --------- Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com> Co-authored-by: Hugo Heuzard <hugo.heuzard@gmail.com>
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Oct 9, 2023
CHANGES: - Fix `dune rpc` commands on Windows (ocaml/dune#8806, fixes ocaml/dune#8799, @nojb) - Fix `inline_tests` when the partition list is empty (ocaml/dune#8849, fixes ocaml/dune#8848, @hhugo)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Fix `dune rpc` commands on Windows (ocaml/dune#8806, fixes ocaml/dune#8799, @nojb) - Fix `inline_tests` when the partition list is empty (ocaml/dune#8849, fixes ocaml/dune#8848, @hhugo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8848
This is a 3 lines fix if your ignore white space