Add "dune describe package-entries" by moyodiallo · Pull Request #7480 · ocaml/dune

moyodiallo · 2023-04-03T17:31:54Z

The need is about knowing if a private executable is going to be installed before building the project.

This PR is related to ocurrent/opam-dune-lint#46:
The command dune describe external-lib does not give the package name of private executable if it going to be installed, dune describe external-lib-deps is used by opam-dune-lint to extract the external dependencies.

rgrinberg · 2023-04-03T19:32:16Z

The implementation looks fine but how about a clearer name like package-entries? entries alone doesn't make it clear what is being printed.

moyodiallo · 2023-04-04T08:12:47Z

The implementation looks fine but how about a clearer name like package-entries? entries alone doesn't make it clear what is being printed.

I buy package-entries.

src/dune_rules/dune_rules.ml

src/dune_rules/install.ml

test/blackbox-tests/test-cases/describe-package-entries.t

emillon · 2023-04-11T15:06:57Z

The implementation is fine, but just to check, does opam-dune-lint work with this PR or is this in anticipation? I'd prefer if we have a clear idea of what's necessary in dune rather than add this "just in case". (and if that's all that is necessary, that's perfect)

moyodiallo · 2023-04-11T15:13:16Z

The implementation is fine, but just to check, does opam-dune-lint work with this PR or is this in anticipation? I'd prefer if we have a clear idea of what's necessary in dune rather than add this "just in case". (and if that's all that is necessary, that's perfect)

I have already tested with opam-dune-lint. I'm working on finishing opam-dune-lint. I had an intention to notify it, after matching the all needs of opam-dune-lint.

emillon · 2023-04-11T15:18:46Z

ok then I'd hold off onto merging these PRs until they've been tested with opam-dune-lint. let me know what that's the case.

moyodiallo · 2023-04-18T14:06:33Z

Ready for another review and to be merged.

emillon · 2023-04-20T09:52:24Z

has this been tested with opam-dune-lint?

bin/describe.ml

src/dune_rules/install.ml

src/dune_rules/install_rules.ml

moyodiallo · 2023-06-08T15:47:29Z

@emillon Ready to move forward, the needs are already addressed. Same as #7478.

bin/describe.ml

src/dune_rules/install.ml

test/blackbox-tests/test-cases/describe-package-entries.t

src/dune_rules/install.ml

Alizter · 2023-06-08T20:05:39Z

FTR I am in the middle of a big refactoring of dune describe. It might make sense to wait for that. Notably you will have to introduce a new subcommand for package-entries.

split describe into cmdliner subcommands #7919

emillon · 2023-06-09T09:10:51Z

FTR I am in the middle of a big refactoring of dune describe. It might make sense to wait for that. Notably you will have to introduce a new subcommand for package-entries.

split describe into cmdliner subcommands #7919

I wouldn't put an order between those. Both branches exist and a rebase will have to be done, it can be done in a direction or the other.

Alizter · 2023-06-16T19:01:09Z

It looks like my branch got merged first. Could you add a package_entries.ml file to bin/describe/ and follow the other describe commands? Let me know if you need any help.

bin/describe/package_entries.ml

Alizter

LGTM, can you add a package_entries.mli?

bin/describe/package_entries.mli

emillon

Looks good once the to_dyn is changed!

src/install/entry.ml

emillon · 2023-07-07T09:39:09Z

Can you promote the tests and add a changelog entry?

test/blackbox-tests/test-cases/describe-package-entries.t

bin/describe/package_entries.ml

emillon · 2023-07-12T13:34:44Z

ping?

The need is about knowing if a private executable is going to be installed before building the project. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

Co-authored-by: Etienne Millon <etienne.millon@gmail.com> Signed-off-by: Alpha Issiaga DIALLO <alpha@tarides.com>

Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

@Alizter

CHANGES: - Add `dune show rules` as alias of the `dune rules` command. (ocaml/dune#8000, @Alizter) - Fix `%{deps}` to expand properly in `(cat ...)` when containing 2 or more items. (ocaml/dune#8196, @Alizter) - Add `dune show installed-libraries` as an alias of the `dune installed-libraries` command. (ocaml/dune#8135, @Alizter) - Fix the `severity` of error messages sent over RPC which was missing. (ocaml/dune#8193, @Alizter) - Add `dune build --dump-gc-stats FILE` argument to dump garbage collection stats to a named file. (ocaml/dune#8072, @Alizter) - Fix bug with ppx and Reason syntax due to missing dependency in sandboxed action (ocaml/dune#7932, fixes ocaml/dune#7930, @Alizter) - Add `dune describe package-entries` to print all package entries (ocaml/dune#7480, @moyodiallo) - Improve `dune describe external-lib-deps` by adding the internal dependencies for more information. (ocaml/dune#7478, @moyodiallo) - Re-enable background file digests on Windows. The files are now open in a way that prevents race condition around deletion. (ocaml/dune#8262, fixes ocaml/dune#8268, @emillon)

@Alizter

CHANGES: - Add `dune show rules` as alias of the `dune rules` command. (ocaml/dune#8000, @Alizter) - Fix `%{deps}` to expand properly in `(cat ...)` when containing 2 or more items. (ocaml/dune#8196, @Alizter) - Add `dune show installed-libraries` as an alias of the `dune installed-libraries` command. (ocaml/dune#8135, @Alizter) - Fix the `severity` of error messages sent over RPC which was missing. (ocaml/dune#8193, @Alizter) - Add `dune build --dump-gc-stats FILE` argument to dump garbage collection stats to a named file. (ocaml/dune#8072, @Alizter) - Fix bug with ppx and Reason syntax due to missing dependency in sandboxed action (ocaml/dune#7932, fixes ocaml/dune#7930, @Alizter) - Add `dune describe package-entries` to print all package entries (ocaml/dune#7480, @moyodiallo) - Improve `dune describe external-lib-deps` by adding the internal dependencies for more information. (ocaml/dune#7478, @moyodiallo) - Re-enable background file digests on Windows. The files are now open in a way that prevents race condition around deletion. (ocaml/dune#8262, fixes ocaml/dune#8268, @emillon)

* Add "dune describe entries" The need is about knowing if a private executable is going to be installed before building the project. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com> Co-authored-by: Etienne Millon <etienne.millon@gmail.com>

@Alizter

CHANGES: - Add `dune show rules` as alias of the `dune rules` command. (ocaml/dune#8000, @Alizter) - Fix `%{deps}` to expand properly in `(cat ...)` when containing 2 or more items. (ocaml/dune#8196, @Alizter) - Add `dune show installed-libraries` as an alias of the `dune installed-libraries` command. (ocaml/dune#8135, @Alizter) - Fix the `severity` of error messages sent over RPC which was missing. (ocaml/dune#8193, @Alizter) - Add `dune build --dump-gc-stats FILE` argument to dump garbage collection stats to a named file. (ocaml/dune#8072, @Alizter) - Fix bug with ppx and Reason syntax due to missing dependency in sandboxed action (ocaml/dune#7932, fixes ocaml/dune#7930, @Alizter) - Add `dune describe package-entries` to print all package entries (ocaml/dune#7480, @moyodiallo) - Improve `dune describe external-lib-deps` by adding the internal dependencies for more information. (ocaml/dune#7478, @moyodiallo) - Re-enable background file digests on Windows. The files are now open in a way that prevents race condition around deletion. (ocaml/dune#8262, fixes ocaml/dune#8268, @emillon)

moyodiallo mentioned this pull request Apr 3, 2023

Fix for "dune external-lib-deps" command ocurrent/opam-dune-lint#46

Merged

moyodiallo marked this pull request as ready for review April 4, 2023 09:22

Alizter changed the title ~~Add "dune describe entries"~~ Add "dune describe package-entries" Apr 4, 2023

rgrinberg requested a review from emillon April 4, 2023 19:27

emillon requested changes Apr 11, 2023

View reviewed changes

src/dune_rules/dune_rules.ml Outdated Show resolved Hide resolved

src/dune_rules/install.ml Outdated Show resolved Hide resolved

test/blackbox-tests/test-cases/describe-package-entries.t Outdated Show resolved Hide resolved

moyodiallo force-pushed the describe-entries branch 2 times, most recently from 4e6ee5b to 2d7b54a Compare April 18, 2023 10:23

moyodiallo requested a review from emillon April 18, 2023 14:06

emillon mentioned this pull request Apr 20, 2023

Improve "dune describe external-lib-deps" : printing out more information #7478

Merged

emillon requested changes Apr 20, 2023

View reviewed changes

moyodiallo force-pushed the describe-entries branch from 2d7b54a to 833cfb6 Compare April 20, 2023 11:35

emillon mentioned this pull request Apr 20, 2023

refactor: extract modules from Install_rules #7590

Closed

Alizter mentioned this pull request May 8, 2023

Support for BUILD_PATH_PREFIX_MAP #7540

Closed

emillon reviewed Jun 8, 2023

View reviewed changes

bin/describe.ml Outdated Show resolved Hide resolved

src/dune_rules/install.ml Outdated Show resolved Hide resolved

moyodiallo requested a review from emillon June 8, 2023 17:04

rgrinberg reviewed Jun 8, 2023

View reviewed changes

test/blackbox-tests/test-cases/describe-package-entries.t Outdated Show resolved Hide resolved

rgrinberg reviewed Jun 8, 2023

View reviewed changes

src/dune_rules/install.ml Outdated Show resolved Hide resolved

moyodiallo force-pushed the describe-entries branch from a125378 to 1172a74 Compare June 9, 2023 10:19

moyodiallo force-pushed the describe-entries branch from 1172a74 to 2ed946e Compare June 27, 2023 10:18

moyodiallo force-pushed the describe-entries branch from fd912a9 to 4dbe205 Compare June 27, 2023 12:06

moyodiallo requested a review from rgrinberg June 27, 2023 12:09

Alizter reviewed Jun 27, 2023

View reviewed changes

bin/describe/package_entries.ml Outdated Show resolved Hide resolved

Alizter reviewed Jun 27, 2023

View reviewed changes

bin/describe/package_entries.ml Outdated Show resolved Hide resolved

Alizter approved these changes Jun 27, 2023

View reviewed changes

moyodiallo force-pushed the describe-entries branch from 4dbe205 to 056c257 Compare June 27, 2023 14:26

Alizter reviewed Jun 27, 2023

View reviewed changes

bin/describe/package_entries.mli Outdated Show resolved Hide resolved

moyodiallo force-pushed the describe-entries branch from 056c257 to 4afd670 Compare June 27, 2023 14:50

moyodiallo force-pushed the describe-entries branch from 4afd670 to 3d6d3b2 Compare July 7, 2023 08:06

emillon reviewed Jul 7, 2023

View reviewed changes

src/install/entry.ml Outdated Show resolved Hide resolved

Alizter reviewed Jul 7, 2023

View reviewed changes

test/blackbox-tests/test-cases/describe-package-entries.t Outdated Show resolved Hide resolved

moyodiallo force-pushed the describe-entries branch from ab3dc80 to 3fc38f5 Compare July 7, 2023 10:54

Alizter reviewed Jul 7, 2023

View reviewed changes

bin/describe/package_entries.ml Outdated Show resolved Hide resolved

moyodiallo force-pushed the describe-entries branch from 3fc38f5 to 7eb736f Compare July 7, 2023 14:05

moyodiallo force-pushed the describe-entries branch from 7eb736f to 1978a38 Compare July 24, 2023 09:26

moyodiallo and others added 4 commits July 24, 2023 13:04

Add "dune describe entries"

8d0d819

The need is about knowing if a private executable is going to be installed before building the project. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

Update src/install/entry.ml

20b87be

Co-authored-by: Etienne Millon <etienne.millon@gmail.com> Signed-off-by: Alpha Issiaga DIALLO <alpha@tarides.com>

Fix tests

6ae4006

Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

Update changelog

15871bd

Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

emillon force-pushed the describe-entries branch from 94914b4 to 15871bd Compare July 24, 2023 11:09

emillon merged commit 8aeadd5 into ocaml:main Jul 24, 2023

moyodiallo deleted the describe-entries branch July 24, 2023 11:47

emillon mentioned this pull request Jul 28, 2023

[new release] dune (15 packages) (3.10.0~alpha1) ocaml/opam-repository#24170

Closed

emillon mentioned this pull request Jul 31, 2023

[new release] dune (15 packages) (3.10.0) ocaml/opam-repository#24185

Merged

Conversation

moyodiallo commented Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rgrinberg commented Apr 3, 2023

Uh oh!

moyodiallo commented Apr 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emillon commented Apr 11, 2023

Uh oh!

moyodiallo commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emillon commented Apr 11, 2023

Uh oh!

moyodiallo commented Apr 18, 2023

Uh oh!

emillon commented Apr 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moyodiallo commented Jun 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alizter commented Jun 8, 2023

Uh oh!

emillon commented Jun 9, 2023

Uh oh!

Alizter commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alizter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emillon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emillon commented Jul 7, 2023

Uh oh!

Uh oh!

Uh oh!

emillon commented Jul 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

moyodiallo commented Apr 3, 2023 •

edited

Loading

moyodiallo commented Apr 11, 2023 •

edited

Loading

Alizter commented Jun 16, 2023 •

edited

Loading