Improve "dune describe external-lib-deps" : printing out more information by moyodiallo · Pull Request #7478 · ocaml/dune

moyodiallo · 2023-04-03T14:29:57Z

Instead of having only external dependencies, we could also add the internal dependencies for more information.

This is related to ocurrent/opam-dune-lint#46.

emillon

Looks fine except some minor style suggestions. Same remark as #7480, has this been tested with opam-dune-lint or is it in anticipation?

bin/describe.ml

moyodiallo · 2023-04-18T14:07:19Z

Ready for another review and to be merged.

emillon · 2023-04-20T09:52:51Z

same question as in #7480, has this been tested with opam-dune-lint?

bin/describe.ml

bin/describe/describe_external_lib_deps.ml

Alizter · 2023-06-27T16:02:30Z

bin/describe/describe_external_lib_deps.ml

-              ~f:(fun name ->
-                external_resolve db (Lib_name.of_string name) Kind.Optional)
-            >>| List.filter_opt)
+      | Dune_rules.Lib_dep.Direct (_, name)


You should put (lib : Dune_rules.Lib_dep.t) in the match then you can stop prefixing the constructors.

bin/describe/describe_external_lib_deps.ml

emillon · 2023-07-07T09:57:15Z

There was a missing ) in my suggestion, sorry. Also can you add a changelog entry?

emillon · 2023-07-12T13:34:53Z

ping?

Instead of having only external dependencies, we could also add the internal dependencies for more information. Add the extensions of executables Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

If a private lib is a dependency and have an external lib as dependency, that information should be known. In order to reach all external dependencies. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

Co-authored-by: Etienne Millon <etienne.millon@gmail.com> Signed-off-by: Alpha Issiaga DIALLO <alpha@tarides.com>

Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

@Alizter

CHANGES: - Add `dune show rules` as alias of the `dune rules` command. (ocaml/dune#8000, @Alizter) - Fix `%{deps}` to expand properly in `(cat ...)` when containing 2 or more items. (ocaml/dune#8196, @Alizter) - Add `dune show installed-libraries` as an alias of the `dune installed-libraries` command. (ocaml/dune#8135, @Alizter) - Fix the `severity` of error messages sent over RPC which was missing. (ocaml/dune#8193, @Alizter) - Add `dune build --dump-gc-stats FILE` argument to dump garbage collection stats to a named file. (ocaml/dune#8072, @Alizter) - Fix bug with ppx and Reason syntax due to missing dependency in sandboxed action (ocaml/dune#7932, fixes ocaml/dune#7930, @Alizter) - Add `dune describe package-entries` to print all package entries (ocaml/dune#7480, @moyodiallo) - Improve `dune describe external-lib-deps` by adding the internal dependencies for more information. (ocaml/dune#7478, @moyodiallo) - Re-enable background file digests on Windows. The files are now open in a way that prevents race condition around deletion. (ocaml/dune#8262, fixes ocaml/dune#8268, @emillon)

@Alizter

CHANGES: - Add `dune show rules` as alias of the `dune rules` command. (ocaml/dune#8000, @Alizter) - Fix `%{deps}` to expand properly in `(cat ...)` when containing 2 or more items. (ocaml/dune#8196, @Alizter) - Add `dune show installed-libraries` as an alias of the `dune installed-libraries` command. (ocaml/dune#8135, @Alizter) - Fix the `severity` of error messages sent over RPC which was missing. (ocaml/dune#8193, @Alizter) - Add `dune build --dump-gc-stats FILE` argument to dump garbage collection stats to a named file. (ocaml/dune#8072, @Alizter) - Fix bug with ppx and Reason syntax due to missing dependency in sandboxed action (ocaml/dune#7932, fixes ocaml/dune#7930, @Alizter) - Add `dune describe package-entries` to print all package entries (ocaml/dune#7480, @moyodiallo) - Improve `dune describe external-lib-deps` by adding the internal dependencies for more information. (ocaml/dune#7478, @moyodiallo) - Re-enable background file digests on Windows. The files are now open in a way that prevents race condition around deletion. (ocaml/dune#8262, fixes ocaml/dune#8268, @emillon)

…tion (ocaml#7478) * refactor: improve "dune describe external-lib-deps" Instead of having only external dependencies, we could also add the internal dependencies for more information. If a private lib is a dependency and have an external lib as dependency, that information should be known. In order to reach all external dependencies. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com> Co-authored-by: Etienne Millon <etienne.millon@gmail.com>

@Alizter

CHANGES: - Add `dune show rules` as alias of the `dune rules` command. (ocaml/dune#8000, @Alizter) - Fix `%{deps}` to expand properly in `(cat ...)` when containing 2 or more items. (ocaml/dune#8196, @Alizter) - Add `dune show installed-libraries` as an alias of the `dune installed-libraries` command. (ocaml/dune#8135, @Alizter) - Fix the `severity` of error messages sent over RPC which was missing. (ocaml/dune#8193, @Alizter) - Add `dune build --dump-gc-stats FILE` argument to dump garbage collection stats to a named file. (ocaml/dune#8072, @Alizter) - Fix bug with ppx and Reason syntax due to missing dependency in sandboxed action (ocaml/dune#7932, fixes ocaml/dune#7930, @Alizter) - Add `dune describe package-entries` to print all package entries (ocaml/dune#7480, @moyodiallo) - Improve `dune describe external-lib-deps` by adding the internal dependencies for more information. (ocaml/dune#7478, @moyodiallo) - Re-enable background file digests on Windows. The files are now open in a way that prevents race condition around deletion. (ocaml/dune#8262, fixes ocaml/dune#8268, @emillon)

rgrinberg requested a review from emillon April 3, 2023 17:09

moyodiallo mentioned this pull request Apr 3, 2023

Fix for "dune external-lib-deps" command ocurrent/opam-dune-lint#46

Merged

moyodiallo marked this pull request as ready for review April 4, 2023 09:22

emillon reviewed Apr 11, 2023

View reviewed changes

bin/describe.ml Outdated Show resolved Hide resolved

bin/describe.ml Outdated Show resolved Hide resolved

moyodiallo requested a review from emillon April 18, 2023 14:07

emillon reviewed Apr 20, 2023

View reviewed changes

bin/describe.ml Outdated Show resolved Hide resolved

moyodiallo force-pushed the internal-dune-describe-externals branch from feb5795 to 59af844 Compare April 20, 2023 11:12

moyodiallo force-pushed the internal-dune-describe-externals branch from 59af844 to 6a061d0 Compare May 19, 2023 15:46

moyodiallo force-pushed the internal-dune-describe-externals branch from 6a061d0 to 97b9172 Compare June 8, 2023 15:27

moyodiallo mentioned this pull request Jun 8, 2023

Add "dune describe package-entries" #7480

Merged

moyodiallo force-pushed the internal-dune-describe-externals branch from 97b9172 to ee6aa27 Compare June 27, 2023 12:02

moyodiallo requested a review from emillon June 27, 2023 12:09

Alizter reviewed Jun 27, 2023

View reviewed changes

bin/describe/describe_external_lib_deps.ml Outdated Show resolved Hide resolved

moyodiallo force-pushed the internal-dune-describe-externals branch from ee6aa27 to 6a21c2b Compare June 27, 2023 15:23

Alizter reviewed Jun 27, 2023

View reviewed changes

bin/describe/describe_external_lib_deps.ml Outdated Show resolved Hide resolved

moyodiallo force-pushed the internal-dune-describe-externals branch from 6a21c2b to 7fc23e1 Compare June 27, 2023 16:27

moyodiallo force-pushed the internal-dune-describe-externals branch 3 times, most recently from 9865cee to 0eec296 Compare July 7, 2023 09:10

emillon reviewed Jul 7, 2023

View reviewed changes

bin/describe/describe_external_lib_deps.ml Outdated Show resolved Hide resolved

bin/describe/describe_external_lib_deps.ml Outdated Show resolved Hide resolved

moyodiallo force-pushed the internal-dune-describe-externals branch from 9055d5d to 44a5eff Compare July 24, 2023 09:48

moyodiallo and others added 4 commits July 24, 2023 13:10

refactor: improve "dune describe external-lib-deps"

677cff4

Instead of having only external dependencies, we could also add the internal dependencies for more information. Add the extensions of executables Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

A private lib could be a dependency

335d442

If a private lib is a dependency and have an external lib as dependency, that information should be known. In order to reach all external dependencies. Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

Update bin/describe/describe_external_lib_deps.ml

499e868

Co-authored-by: Etienne Millon <etienne.millon@gmail.com> Signed-off-by: Alpha Issiaga DIALLO <alpha@tarides.com>

Update bin/describe/describe_external_lib_deps.ml

a6da29e

Co-authored-by: Etienne Millon <etienne.millon@gmail.com> Signed-off-by: Alpha Issiaga DIALLO <alpha@tarides.com>

moyodiallo added 2 commits July 24, 2023 13:10

refactor the code

fa073c4

Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

Update changelog

2c67b7a

Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>

emillon force-pushed the internal-dune-describe-externals branch from 44a5eff to 2c67b7a Compare July 24, 2023 11:11

emillon merged commit 875fc23 into ocaml:main Jul 24, 2023

moyodiallo deleted the internal-dune-describe-externals branch July 24, 2023 11:47

rgrinberg added this to the 3.10.0 milestone Jul 24, 2023

emillon mentioned this pull request Jul 28, 2023

[new release] dune (15 packages) (3.10.0~alpha1) ocaml/opam-repository#24170

Closed

emillon mentioned this pull request Jul 31, 2023

[new release] dune (15 packages) (3.10.0) ocaml/opam-repository#24185

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve "dune describe external-lib-deps" : printing out more information #7478

Improve "dune describe external-lib-deps" : printing out more information #7478
emillon merged 6 commits intoocaml:mainfrom
moyodiallo:internal-dune-describe-externals

moyodiallo commented Apr 3, 2023

Uh oh!

emillon left a comment

Uh oh!

Uh oh!

Uh oh!

moyodiallo commented Apr 18, 2023

Uh oh!

emillon commented Apr 20, 2023

Uh oh!

Uh oh!

Uh oh!

Alizter Jun 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emillon commented Jul 7, 2023

Uh oh!

emillon commented Jul 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

moyodiallo commented Apr 3, 2023

Uh oh!

emillon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

moyodiallo commented Apr 18, 2023

Uh oh!

emillon commented Apr 20, 2023

Uh oh!

Uh oh!

Uh oh!

Alizter Jun 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emillon commented Jul 7, 2023

Uh oh!

emillon commented Jul 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants