refactor: remove temporary map used for sorting#6472
Merged
Conversation
Using List.sort is just as good and [FileMap] violated our casing convention Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: b09c7aa4-8014-4e9e-8d1d-18fb2b1e24d6
Alizter
approved these changes
Nov 15, 2022
emillon
approved these changes
Nov 15, 2022
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 16, 2022
* main: test(melange): demonstrate error in melange compilation trying to build @ALL (ocaml#6485) chore(nix): make it faster to get melange (ocaml#6347) refactor: status db style tweaks (ocaml#6478) fix: improve error message for status db (ocaml#6479) refactor: remove unused [flags] parameter (ocaml#6480) refactor(ctypes): remove pesky aliases (ocaml#6482) chore: tweak `hacking.rst` following `dune.exe` move to _boot (ocaml#6484) feature(coq): automatic detection of native chore(coq): bump Coq lang to 0.7 test: disable formatting for a single dune file (ocaml#6465) refactor: clean up module compilation (ocaml#6461) doc: add button to copy code blocks in Dune manual (ocaml#6428) refactor: deforest a set conversion (ocaml#6473) refactor: remove temporary map used for sorting (ocaml#6472) fix(melange): handle include_subdirs unqualified (ocaml#6475)
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 16, 2022
* main: test(melange): demonstrate error in melange compilation trying to build @ALL (ocaml#6485) chore(nix): make it faster to get melange (ocaml#6347) refactor: status db style tweaks (ocaml#6478) fix: improve error message for status db (ocaml#6479) refactor: remove unused [flags] parameter (ocaml#6480) refactor(ctypes): remove pesky aliases (ocaml#6482) chore: tweak `hacking.rst` following `dune.exe` move to _boot (ocaml#6484) feature(coq): automatic detection of native chore(coq): bump Coq lang to 0.7 test: disable formatting for a single dune file (ocaml#6465) refactor: clean up module compilation (ocaml#6461) doc: add button to copy code blocks in Dune manual (ocaml#6428) refactor: deforest a set conversion (ocaml#6473) refactor: remove temporary map used for sorting (ocaml#6472) fix(melange): handle include_subdirs unqualified (ocaml#6475)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using List.sort is just as good and [FileMap] violated our casing
convention
Signed-off-by: Rudi Grinberg me@rgrinberg.com
ps-id: b09c7aa4-8014-4e9e-8d1d-18fb2b1e24d6