Skip to content

refactor: clean up module compilation#6461

Merged
rgrinberg merged 1 commit intomainfrom
ps/rr/refactor__clean_up_module_compilation
Nov 15, 2022
Merged

refactor: clean up module compilation#6461
rgrinberg merged 1 commit intomainfrom
ps/rr/refactor__clean_up_module_compilation

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

  • reduce scope of bindings
  • add a helper for melange args

Signed-off-by: Rudi Grinberg me@rgrinberg.com

ps-id: e4059d8b-6f96-4b2a-9fad-a787c0aa73f8

* reduce scope of bindings
* add a helper for melange args

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

ps-id: e4059d8b-6f96-4b2a-9fad-a787c0aa73f8
@rgrinberg rgrinberg force-pushed the ps/rr/refactor__clean_up_module_compilation branch from 7ebfbc7 to e96b56a Compare November 14, 2022 14:36
@rgrinberg rgrinberg merged commit 3fa2cc2 into main Nov 15, 2022
jchavarri added a commit to jchavarri/dune that referenced this pull request Nov 16, 2022
* main:
  test(melange): demonstrate error in melange compilation trying to build @ALL (ocaml#6485)
  chore(nix): make it faster to get melange (ocaml#6347)
  refactor: status db style tweaks (ocaml#6478)
  fix: improve error message for status db (ocaml#6479)
  refactor: remove unused [flags] parameter (ocaml#6480)
  refactor(ctypes): remove pesky aliases (ocaml#6482)
  chore: tweak `hacking.rst` following `dune.exe` move to _boot (ocaml#6484)
  feature(coq): automatic detection of native
  chore(coq): bump Coq lang to 0.7
  test: disable formatting for a single dune file (ocaml#6465)
  refactor: clean up module compilation (ocaml#6461)
  doc: add button to copy code blocks in Dune manual (ocaml#6428)
  refactor: deforest a set conversion (ocaml#6473)
  refactor: remove temporary map used for sorting (ocaml#6472)
  fix(melange): handle include_subdirs unqualified (ocaml#6475)
jchavarri added a commit to jchavarri/dune that referenced this pull request Nov 16, 2022
* main:
  test(melange): demonstrate error in melange compilation trying to build @ALL (ocaml#6485)
  chore(nix): make it faster to get melange (ocaml#6347)
  refactor: status db style tweaks (ocaml#6478)
  fix: improve error message for status db (ocaml#6479)
  refactor: remove unused [flags] parameter (ocaml#6480)
  refactor(ctypes): remove pesky aliases (ocaml#6482)
  chore: tweak `hacking.rst` following `dune.exe` move to _boot (ocaml#6484)
  feature(coq): automatic detection of native
  chore(coq): bump Coq lang to 0.7
  test: disable formatting for a single dune file (ocaml#6465)
  refactor: clean up module compilation (ocaml#6461)
  doc: add button to copy code blocks in Dune manual (ocaml#6428)
  refactor: deforest a set conversion (ocaml#6473)
  refactor: remove temporary map used for sorting (ocaml#6472)
  fix(melange): handle include_subdirs unqualified (ocaml#6475)
@Alizter Alizter deleted the ps/rr/refactor__clean_up_module_compilation branch November 26, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants