Check that a test stanza is disabled before generating the rules#6134
Closed
voodoos wants to merge 3 commits intoocaml:mainfrom
Closed
Check that a test stanza is disabled before generating the rules#6134voodoos wants to merge 3 commits intoocaml:mainfrom
voodoos wants to merge 3 commits intoocaml:mainfrom
Conversation
d9e2a44 to
94ea351
Compare
rgrinberg
reviewed
Sep 8, 2022
rgrinberg
approved these changes
Sep 8, 2022
Member
rgrinberg
left a comment
There was a problem hiding this comment.
Please describe the test and add a CHANGES entry.
voodoos
added a commit
to voodoos/dune
that referenced
this pull request
Sep 8, 2022
94ea351 to
5e456e1
Compare
When a test is disabled dune shouldn't check the availability of its dependencies. Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
This is what is done for executables: no rule is generated if the enabled_if field evaluates to false. Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
Signed-off-by: Ulysse Gérard <thevoodoos@gmail.com>
5e456e1 to
3095ca7
Compare
Collaborator
Author
|
Thanks for the review Rudi ! |
Collaborator
|
It's a dupe of #5529 isn't it? In which case the same review comment applies - we want to preserve the behavior and somehow version it or add a knob to |
Collaborator
Author
|
It is in fact a duplicate... with exactly the same changes, so there is no reason to keep this PR open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike the
executablesstanza, Dune attempted to create some rules for atestseven if it was disabled. This adds a similar check as the one forexecutablesto abort rule generation if the stanza is disabled.This should fix #6132