(test): skip rule creation if enabled_if is false#5529
(test): skip rule creation if enabled_if is false#5529emillon wants to merge 1 commit intoocaml:mainfrom
Conversation
When a `(test)` stanza is disabled through `(enabled_if)`, do not create any rule. This removes spurious "Library X is hidden (unsatisfied `enabled_if`)" error messages. Closes: ocaml#5505 Signed-off-by: Etienne Millon <me@emillon.org>
|
Note that this isn't a bug fix, but a breaking change. The old behavior intentionally disabled running, instead of building the test. We could have a knob to tweak to disable building, but we can't just remove the old behavior. For inline tests, we have knobs both for building and running the tests. We should probably have something similar here. |
|
Can't this be controlled by requiring There's a PR on Eio (ocaml-multicore/eio#416) switching to If I want to build a test but not run it, there are easy ways to do that. |
|
I still think that it doesn't make sense to favor one over the other. In retrospect, we should have had |
|
Is this behaviour documented anywhere? I assumed It might make sense to have a |
|
You have a point that the correct interpretation of |
When a
(test)stanza is disabled through(enabled_if), do not create any rule. This removes spurious "Library X is hidden (unsatisfiedenabled_if)" error messages.