Allow list expansion in preprocessor arguments#5820
Closed
Firobe wants to merge 2 commits intoocaml:mainfrom
Firobe:fix/ppx-args-allow-list-expansion
Closed
Allow list expansion in preprocessor arguments#5820Firobe wants to merge 2 commits intoocaml:mainfrom Firobe:fix/ppx-args-allow-list-expansion
Firobe wants to merge 2 commits intoocaml:mainfrom
Firobe:fix/ppx-args-allow-list-expansion
Conversation
Member
|
Thanks for the PR. We need a few more changes to merge it though:
If you have any questions on how to do the above, please don't hesitate to ask. |
25 tasks
Contributor
Author
|
Hey @rgrinberg, I have a test but I'm not against some help to retrieve the current dune lang version, in particular how to escape the |
Member
|
You can obtain the version from |
Contributor
Author
|
Thank you! I think the PR is ready to be reviewed again. For the test, I tested the new behavior in a separate test for the (yet non-existent) version 3.3, after checking that the behavior actually works if there is no version guard. I'm not sure if you have a process for writing tests for the version currently in development. |
Only enably new behavior for dune above 3.2 Signed-off-by: Virgile Robles <virgile.robles@protonmail.ch>
Signed-off-by: Virgile Robles <virgile.robles@protonmail.ch>
Member
|
Merged. Thanks. |
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jun 17, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.3.0) CHANGES: - Sandbox preprocessing, lint, and dialect rules by default. All these rules now require precise dependency specifications (ocaml/dune#5807, @rgrinberg) - Allow list expansion in the `pps` specification for preprocessing (ocaml/dune#5820, @Firobe) - Add warnings 67-69 to dune's default set of warnings. These are warnings of the form "unused X.." (ocaml/dune#5844, @rgrinbreg) - Introduce project "composition" for coq theories. Coq theories in separate projects can now refer to each other when in the same workspace (ocaml/dune#5784, @Alitzer, @rgrinberg) - Fix hint message for ``data_only_dirs`` that wrongly mentions the unknown constructor ``data_only`` (ocaml/dune#5803, @lambdaxdotx) - Fix creating sandbox directory trees by getting rid of buggy memoization (@5794, @rgrinberg, @snowleopard) - Handle directory dependencies in sandboxed rules. Previously, the parents of these directory dependencies weren't created. (ocaml/dune#5754, @rgrinberg) - Set the exit code to 130 when dune is terminated with a signal (ocaml/dune#5769, fixes ocaml/dune#5757) - Support new locations of unix, str, dynlink in OCaml >= 5.0 (ocaml/dune#5582, @dra27) - The ``coq.theory`` stanza now produces rules for running ``coqdoc``. Given a theory named ``mytheory``, the directory targets ``mytheory.html/`` and ``mytheory.tex/`` or additionally the aliases `@doc` and `@doc-latex` will build the HTML and LaTeX documentation repsectively. (ocaml/dune#5695, fixes ocaml/dune#3760, @Alizter) - Coq theories marked as `(boot)` cannot depend on other theories (ocaml/dune#5867, @ejgallego) - Ignore `bigarray` in `(libraries)` with OCaml >= 5.0. (ocaml/dune#5526, fixes ocaml/dune#5494, @moyodiallo) - Start with :standard when building the ctypes generated foreign stubs so that we include important compiler flags, such as -fPIC (ocaml/dune#5816, fixes ocaml/dune#5809).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows templates to expand into multiple values in preprocessor flags, like:
This makes it consistent with similar usage of
read-linesforrunto pass correctly separated arguments.