add sandboxing to ocamldep, lint, dialect, pp#5807
Merged
Conversation
b2abf7a to
c913c93
Compare
Collaborator
|
I did some benchmarking on js-monorepo and timed PR:
3.2.0:
I can try to have more precise figures (those are not based on many runs, with parallelism) but yes it looks like it's noticeable. |
Member
Author
|
Thanks Etienne. I'll drop the sandboxing on ocamldep as it's a fairly safe command. I'd like to keep sandboxing on preprocessing even if it there is a small penalty. It's an issue of correctness for user rules so it's worth making sure these are actually solid. |
c913c93 to
aa222ce
Compare
Collaborator
|
Am I reading the results correctly? It looks like it was faster with this PR? |
Collaborator
|
I tried to retime this but TBH the numbers are all over the place with my measuring setup so I don't think we rely on them too much. |
Member
Author
|
Let me do some tests as well then. |
Collaborator
|
Just now I did some informal tests under Windows doing a build from scratch of the LexiFi codebase, but the difference seems to be noise: This PR: 4m39 4m29 4m30 |
Collaborator
|
Would it perhaps be more noticeable if we restrict to a single job? |
aa222ce to
47e0687
Compare
Member
Author
|
Okay, I did some benchmarks and there's essentially no overhead. |
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 6E2A6828-EB8A-4727-B2BA-344D665D340C
47e0687 to
98ce9cd
Compare
kit-ty-kate
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jun 17, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.3.0) CHANGES: - Sandbox preprocessing, lint, and dialect rules by default. All these rules now require precise dependency specifications (ocaml/dune#5807, @rgrinberg) - Allow list expansion in the `pps` specification for preprocessing (ocaml/dune#5820, @Firobe) - Add warnings 67-69 to dune's default set of warnings. These are warnings of the form "unused X.." (ocaml/dune#5844, @rgrinbreg) - Introduce project "composition" for coq theories. Coq theories in separate projects can now refer to each other when in the same workspace (ocaml/dune#5784, @Alitzer, @rgrinberg) - Fix hint message for ``data_only_dirs`` that wrongly mentions the unknown constructor ``data_only`` (ocaml/dune#5803, @lambdaxdotx) - Fix creating sandbox directory trees by getting rid of buggy memoization (@5794, @rgrinberg, @snowleopard) - Handle directory dependencies in sandboxed rules. Previously, the parents of these directory dependencies weren't created. (ocaml/dune#5754, @rgrinberg) - Set the exit code to 130 when dune is terminated with a signal (ocaml/dune#5769, fixes ocaml/dune#5757) - Support new locations of unix, str, dynlink in OCaml >= 5.0 (ocaml/dune#5582, @dra27) - The ``coq.theory`` stanza now produces rules for running ``coqdoc``. Given a theory named ``mytheory``, the directory targets ``mytheory.html/`` and ``mytheory.tex/`` or additionally the aliases `@doc` and `@doc-latex` will build the HTML and LaTeX documentation repsectively. (ocaml/dune#5695, fixes ocaml/dune#3760, @Alizter) - Coq theories marked as `(boot)` cannot depend on other theories (ocaml/dune#5867, @ejgallego) - Ignore `bigarray` in `(libraries)` with OCaml >= 5.0. (ocaml/dune#5526, fixes ocaml/dune#5494, @moyodiallo) - Start with :standard when building the ctypes generated foreign stubs so that we include important compiler flags, such as -fPIC (ocaml/dune#5816, fixes ocaml/dune#5809).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.