Conversation
711f057 to
4667f3b
Compare
| match t.kind with | ||
| | Sourcehut -> assert false | ||
| | Bitbucket | Github -> "/issues" | ||
| | Gitlab -> "/-/issues") |
There was a problem hiding this comment.
The current implementation is fine, but I wonder if this would be even simpler to inline the intermediate abstractions and do a "plain" pattern matching. There will be some duplication, but the various hosts we support are already slightly different.
There was a problem hiding this comment.
There's a way to factor this stuff out better most certainly. I did not try very hard I admit.
|
ping @emillon needs an approval |
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 06A1825D-D6F9-425E-BFD5-38A953F1C27B
4667f3b to
54c7019
Compare
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.1.0) CHANGES: - Add `sourcehut` as an option for defining project sources in dune-project files. For example, `(source (sourcehut user/repo))`. (ocaml/dune#5564, @rgrinberg) - Add `dune coq top` command for running a Coq toplevel (ocaml/dune#5457, @rlepigre) - Fix dune exec dumping database in wrong directory (ocaml/dune#5544, @bobot) - Always output absolute paths for locations in RPC reported diagnostics (ocaml/dune#5539, @rgrinberg) - Add `(deps <deps>)` in ctype field (ocaml/dune#5346, @bobot) - Add `(include <file>)` constructor to dependency specifications. This can be used to introduce dynamic dependencies (ocaml/dune#5442, @anmonteiro) - Ensure that `dune describe` computes a transitively closed set of libraries (ocaml/dune#5395, @esope) - Add direct dependencies to $ dune describe output (ocaml/dune#5412, @esope) - Show auto-detected concurrency on Windows too (ocaml/dune#5502, @MisterDA) - Fix operations that remove folders with absolute path. This happens when using esy (ocaml/dune#5507, @EduardoRFS) - Dune will not fail if some directories are non-empty when uninstalling. (ocaml/dune#5543, fixes ocaml/dune#5542, @nojb) - `coqdep` now depends only on the filesystem layout of the .v files, and not on their contents (ocaml/dune#5547, helps with ocaml/dune#5100, @ejgallego) - The mdx stanza 0.2 can now be used with `(implicit_transitive_deps false)` (ocaml/dune#5558, fixes ocaml/dune#5499, @emillon) - Fix missing parenthesis in printing of corresponding terminal command for `(with-outputs-to )` (ocaml/dune#5551, fixes ocaml/dune#5546, @Alizter)
|
@rgrinberg do I read the code correct, the source stanza is limited to hardcoded platforms? How would I enter an arbitrary url into an opam file - by dune-project or would I rather just write it by hand? |
I think you need the set all the fields individually. Url, homepage, etc. The source stanza is just there to make setting all those fields at once possible. |
|
@mro you don't have to use a template for this, the following should work: |
|
nice, but it looks I need the template for the tags. |
|
Tags are supported, they'll be sourced from |
|
failed for me: |
|
I think it needs to be in the |
|
chapeau! https://codeberg.org/seppo/seppo/commit/7df696110f6f9e17f7106d93e9f7537be20d2fb7 Thanks a lot! |
|
it appears a bit inconsequent that entries end up next to each other but one can be specified outside |
|
Yeah I agree it's not ideal. The reasoning is that things like source, author, maintainer are global to the project but tags are specific to each package. But I think that adding a global version of |
No description provided.