Skip to content

Fix mdx stanza with implicit_transitive_deps false#5558

Merged
emillon merged 1 commit intoocaml:mainfrom
emillon:fix-5499
Apr 12, 2022
Merged

Fix mdx stanza with implicit_transitive_deps false#5558
emillon merged 1 commit intoocaml:mainfrom
emillon:fix-5499

Conversation

@emillon
Copy link
Copy Markdown
Collaborator

@emillon emillon commented Apr 8, 2022

Closes #5499

@emillon
Copy link
Copy Markdown
Collaborator Author

emillon commented Apr 8, 2022

@NathanReb @rgrinberg what do you think about this one? I think it's a bug fix so we don't have to version it against the stanza or (lang dune), but this assumes that mdx.top is going to be available.

@rgrinberg
Copy link
Copy Markdown
Member

what do you think about this one? I think it's a bug fix so we don't have to version it against the stanza

Given that the mdx extension is not stable, we are free to make breaking changes regardless.

but this assumes that mdx.top is going to be available.

When was this library introduced? Can we add a conflict with previous version of mdx?

@emillon
Copy link
Copy Markdown
Collaborator Author

emillon commented Apr 11, 2022

mdx.top has been there since at least 1.0.0 (2018), so we can assume it's there. My concern is more if mdx.top is removed in the future, but that would need to be in a major version anyway.

Closes ocaml#5499

Signed-off-by: Etienne Millon <me@emillon.org>
@rgrinberg
Copy link
Copy Markdown
Member

Then there's no problem with this change.

Copy link
Copy Markdown
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for taking the time to fix this!

@emillon emillon merged commit a27ffbd into ocaml:main Apr 12, 2022
@emillon emillon deleted the fix-5499 branch April 12, 2022 08:50
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Apr 15, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.1.0)

CHANGES:

- Add `sourcehut` as an option for defining project sources in dune-project
  files. For example, `(source (sourcehut user/repo))`. (ocaml/dune#5564, @rgrinberg)

- Add `dune coq top` command for running a Coq toplevel (ocaml/dune#5457, @rlepigre)

- Fix dune exec dumping database in wrong directory (ocaml/dune#5544, @bobot)

- Always output absolute paths for locations in RPC reported diagnostics
  (ocaml/dune#5539, @rgrinberg)

- Add `(deps <deps>)` in ctype field (ocaml/dune#5346, @bobot)

- Add `(include <file>)` constructor to dependency specifications. This can be
  used to introduce dynamic dependencies (ocaml/dune#5442, @anmonteiro)

- Ensure that `dune describe` computes a transitively closed set of
  libraries (ocaml/dune#5395, @esope)

- Add direct dependencies to $ dune describe output (ocaml/dune#5412, @esope)

- Show auto-detected concurrency on Windows too (ocaml/dune#5502, @MisterDA)

- Fix operations that remove folders with absolute path. This happens when
  using esy (ocaml/dune#5507, @EduardoRFS)

- Dune will not fail if some directories are non-empty when uninstalling.
  (ocaml/dune#5543, fixes ocaml/dune#5542, @nojb)

- `coqdep` now depends only on the filesystem layout of the .v files,
  and not on their contents (ocaml/dune#5547, helps with ocaml/dune#5100, @ejgallego)

- The mdx stanza 0.2 can now be used with `(implicit_transitive_deps false)`
  (ocaml/dune#5558, fixes ocaml/dune#5499, @emillon)

- Fix missing parenthesis in printing of corresponding terminal command for
  `(with-outputs-to )` (ocaml/dune#5551, fixes ocaml/dune#5546, @Alizter)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MDX stanza executable fails to build with (implicit_transitive_deps false)

3 participants