Remove reliance on the log file in some cram test#12989
Merged
rgrinberg merged 2 commits intoocaml:mainfrom Dec 17, 2025
Merged
Remove reliance on the log file in some cram test#12989rgrinberg merged 2 commits intoocaml:mainfrom
rgrinberg merged 2 commits intoocaml:mainfrom
Conversation
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Alizter
approved these changes
Dec 17, 2025
Collaborator
|
@rgrinberg I think it would be useful if you could add a paragraph to |
benodiwal
pushed a commit
to benodiwal/dune
that referenced
this pull request
Dec 17, 2025
Use jq and the trace file instead. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Member
Author
|
Sure, but let's wait until things settle down a little more. Currently, there are still some changes I'm planning to make that will require changing many tests.
…On Wed, Dec 17, 2025, at 2:56 PM, Ali Caglayan wrote:
*Alizter* left a comment (ocaml/dune#12989) <#12989 (comment)>
@rgrinberg <https://github.com/rgrinberg> I think it would be useful if you could add a paragraph to `hacking.rst` about `jq` and reading the trace.
—
Reply to this email directly, view it on GitHub <#12989 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABB56ZQVBVITUUI77WXXM34CFVLVAVCNFSM6AAAAACPH6ZJLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRVG4ZTCMJZGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
davesnx
added a commit
to davesnx/dune
that referenced
this pull request
Dec 18, 2025
…without-system * 'main' of github.com:/ocaml/dune: (113 commits) fix: use warning mechanism for duplicate deps warning (ocaml#12986) Remove reliance on the log file in some cram test (ocaml#12989) Remove [set_log_file] (ocaml#12987) fix: account for workspace binaries when generating rules for `./.bin` (ocaml#12952) Revert "Fix/duplicate dependencies warning" (ocaml#12984) refactor: make Package_dependency.decode return located value refactor: use Option.iter chore: updated 2678.md fix: hint message and added CR refactor: convert check_dups to list fold fix: use ~hints parameter for hints fix: warn on all duplicate package names in dependencies chore: added entry for CHANGES.md tests: removed unncessary dune-project file tests: refactor fix: added warning for duplicate dependencies in package definitions fix: tests fix: refactor fix: misleading comment in helpers.sh fix: remove disabled test stanza for deleted tests ...
jonludlam
pushed a commit
to jonludlam/dune
that referenced
this pull request
Jan 14, 2026
Use jq and the trace file instead. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use jq and the trace file instead.
cc @Alizter let's keep this style in mind going forward. It makes for better tests and the log file is going away.