Skip to content

Remove [set_log_file]#12987

Merged
rgrinberg merged 2 commits intoocaml:mainfrom
rgrinberg:remove-set-log-file
Dec 16, 2025
Merged

Remove [set_log_file]#12987
rgrinberg merged 2 commits intoocaml:mainfrom
rgrinberg:remove-set-log-file

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

Dead code

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg merged commit e5269e5 into ocaml:main Dec 16, 2025
23 of 24 checks passed
benodiwal pushed a commit to benodiwal/dune that referenced this pull request Dec 17, 2025
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
davesnx added a commit to davesnx/dune that referenced this pull request Dec 18, 2025
…without-system

* 'main' of github.com:/ocaml/dune: (113 commits)
  fix: use warning mechanism for duplicate deps warning (ocaml#12986)
  Remove reliance on the log file in some cram test (ocaml#12989)
  Remove [set_log_file] (ocaml#12987)
  fix: account for workspace binaries when generating rules for `./.bin` (ocaml#12952)
  Revert "Fix/duplicate dependencies warning" (ocaml#12984)
  refactor: make Package_dependency.decode return located value
  refactor: use Option.iter
  chore: updated 2678.md
  fix: hint message and added CR
  refactor: convert check_dups to list fold
  fix: use ~hints parameter for hints
  fix: warn on all duplicate package names in dependencies
  chore: added entry for CHANGES.md
  tests: removed unncessary dune-project file
  tests: refactor
  fix: added warning for duplicate dependencies in package definitions
  fix: tests
  fix: refactor
  fix: misleading comment in helpers.sh
  fix: remove disabled test stanza for deleted tests
  ...
jonludlam pushed a commit to jonludlam/dune that referenced this pull request Jan 14, 2026
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant