fix: revert dune exec back to spawn#11879
Merged
Alizter merged 2 commits intoocaml:mainfrom Jun 7, 2025
Merged
Conversation
maiste
reviewed
Jun 4, 2025
14f7bc4 to
d5ae1d9
Compare
maiste
approved these changes
Jun 4, 2025
Collaborator
maiste
left a comment
There was a problem hiding this comment.
Comparing with the PR to revert, LGTM 👍
Signed-off-by: Ali Caglayan <alizter@gmail.com>
rgrinberg
approved these changes
Jun 7, 2025
This was referenced Jun 11, 2025
maiste
added a commit
to maiste/opam-repository
that referenced
this pull request
Jun 11, 2025
CHANGES: ### Fixed - Revert changes in `dune exec` behaviour introduced in 3.19.0. (ocaml/dune#11879, fixes ocaml/dune#11870, ocaml/dune#11867 and ocaml/dune#11881, @Alizter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts
dune execto spawn after essentially exiting dune like we had before 3.19.I've overridden the previous "fix"'s changelog from #11876.