fix(exec): Spawn dune exec processes in inherited process group#11876
Merged
Alizter merged 3 commits intoocaml:mainfrom Jun 4, 2025
Merged
fix(exec): Spawn dune exec processes in inherited process group#11876Alizter merged 3 commits intoocaml:mainfrom
Alizter merged 3 commits intoocaml:mainfrom
Conversation
This was referenced May 31, 2025
4446f97 to
6504cd2
Compare
In dune 3.18 we invoked Spawn directly to start a process and in turn we defaulted to inheriting the process group. In 3.19 this was changed to use the process managment given by Dune_engine.Process however there we always spawn processes in a new process group. Terminal sessions typically rely on the process group when doing interactive things like reading lines from the user. This meant we ran into issues such as ocaml#11870 and ocaml#11867. The fix here is to revert back to inheriting the process group. Signed-off-by: Ali Caglayan <alizter@gmail.com>
rgrinberg
approved these changes
Jun 3, 2025
rgrinberg
reviewed
Jun 3, 2025
Signed-off-by: Ali Caglayan <alizter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dune 3.18 we invoked Spawn directly to start a process and in turn we defaulted to inheriting the process group. In 3.19 this was changed to use the process managment given by Dune_engine.Process however here we always spawn processes in a new process group.
Terminal sessions typically rely on the process group when doing interactive things like reading lines from the user. This meant we ran into issues such as #11870 and #11867.
The fix here is to revert back to inheriting the process group.