Merged
Conversation
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Collaborator
Author
|
CI failures look unrelated. |
Collaborator
|
I've retriggered the failing tests manually and some failures are related (albeit easily fixed). |
Collaborator
Author
Thanks, fixed. |
doc/test/run.t
Outdated
| ../melange.rst: (lang dune 3.17) | ||
| ../sites.rst: (lang dune 3.17) | ||
| ../sites.rst: (lang dune 3.17) | ||
| ../sites.rst: (lang dune 3.17) |
Collaborator
There was a problem hiding this comment.
These probably need to be updated, as written in the description above.
This reverts commit ed9c163. Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
e6abd81 to
1f63f3a
Compare
Leonidas-from-XIV
approved these changes
Dec 2, 2024
Collaborator
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Looks good, thanks! The remaining failures are unrelated.
chris-armstrong
pushed a commit
to chris-armstrong/dune
that referenced
this pull request
Jan 29, 2025
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com> Signed-off-by: Chris Armstrong <chris-armstrong@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #11166 (comment)
The second commit fixes the versioning guard of a change that was initially in 3.17 but was later reverted (see #11164).