Skip to content

[3.17] remove breaking change for alpha1#11164

Merged
maiste merged 2 commits intoocaml:3.17from
maiste:prepare-3.17/remove-breaking-change
Nov 27, 2024
Merged

[3.17] remove breaking change for alpha1#11164
maiste merged 2 commits intoocaml:3.17from
maiste:prepare-3.17/remove-breaking-change

Conversation

@maiste
Copy link
Copy Markdown
Collaborator

@maiste maiste commented Nov 27, 2024

This PR reverts the patch made in #10892 for the 3.17.0~alpha1 release. Indeed, while releasing 3.17.0 we have seen that it would break odoc tests because of the indentation. Further discussions have occurred in the PR about how to fix it in main in a more sustainable way. However, we have decided to remove the patch for 3.17.0 and reintroduce it in later released.

…ormatting wrapped lists (ocaml#10892)"

This reverts commit af95981.

Signed-off-by: Etienne Marais <dev@maiste.fr>
Signed-off-by: Etienne Marais <dev@maiste.fr>
@maiste maiste force-pushed the prepare-3.17/remove-breaking-change branch from 39d6b41 to d818c2d Compare November 27, 2024 15:17
Copy link
Copy Markdown
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as this is in agreement with the original author of the feature. @nojb. I also think that it's better to defer this to 3.18 with the improvements discussed in #10892 as that should avoid the issue altogether and not require users patching their builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants