feat(targets): create multiple targets by l1ttps · Pull Request #291 · oasm-platform/open-asm

l1ttps · 2026-03-03T07:09:06Z

No description provided.

gemini-code-assist · 2026-03-03T07:09:28Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the target creation process by removing the workspaceId from the CreateTargetDto and instead deriving it from the request context on the backend. This change enhances security and data integrity by ensuring the workspaceId is managed server-side. Additionally, the creation of primary assets is now an atomic operation within the same database transaction as target creation, preventing inconsistencies.

Highlights

Refactored CreateTargetDto: The CreateTargetDto has been updated across the frontend and backend to no longer include the workspaceId property directly. This streamlines the DTO and shifts responsibility for workspaceId handling.
Backend workspaceId Handling: The workspaceId is now extracted from the request context on the backend using a @WorkspaceId() decorator in the TargetsController, rather than being passed as part of the CreateTargetDto payload from the frontend. This improves security by ensuring the workspaceId is derived server-side.
Atomic Primary Asset Creation: The creation of a target's primary asset has been moved into the same database transaction as the target itself. This ensures atomicity, meaning both the target and its primary asset are created successfully or neither are, maintaining data integrity.
Simplified Event Emission: The logic for emitting the target.create event has been simplified by removing the conditional check for workspaceConfigs.isAssetsDiscovery, implying the event is now always emitted upon target creation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

console/src/components/ui/create-target.tsx
- Removed workspaceId from the data object sent during target creation.
console/src/services/apis/gen/queries.ts
- Updated CreateTargetDto by removing the workspaceId property.
core-api/src/modules/targets/dto/targets.dto.ts
- Refactored CreateTargetDto to no longer include workspaceId as a direct property.
core-api/src/modules/targets/targets.controller.ts
- Modified createTarget method to receive workspaceId via a decorator and pass it to the service layer
- Refactored getTargetById parameter formatting for improved readability.
core-api/src/modules/targets/targets.service.ts
- Imported randomUUID and Asset for primary asset creation.
- Refactored createTarget method to accept workspaceId directly as a parameter.
- Moved primary asset creation into the database transaction for atomicity, including a check for existing assets.
- Simplified event emission logic for target.create by removing conditional checks.
worker/services/core-api/api.ts
- Removed workspaceId property from the CreateTargetDto interface.

Activity

No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the target creation process by removing the workspaceId from the CreateTargetDto and instead passing it as a parameter obtained from the request context. A significant improvement is moving the primary asset creation into the same database transaction as the target creation, which enhances data integrity.

My review has two main points:

A potential issue with unconditionally emitting the target.create event, which was previously conditional. This could lead to unintended asset discovery.
A suggestion to simplify the code by removing a redundant database query within the target creation transaction.

Overall, the changes are positive, especially regarding transactional integrity.

_{Note: Security Review did not run due to the size of the PR.}

gemini-code-assist · 2026-03-03T07:11:56Z

core-api/src/modules/targets/targets.service.ts

-    if (workspaceConfigs.isAssetsDiscovery) {
-      this.eventEmitter.emit('target.create', target);
-    }
+    this.eventEmitter.emit('target.create', target);


The asset discovery event target.create is now emitted unconditionally. Previously, it was only emitted if isAssetsDiscovery was enabled for the workspace. This change might trigger asset discovery for workspaces where it's disabled, which could be an unintended behavior. If this is not the case, please clarify in the PR description. Otherwise, consider reintroducing the conditional check:

const workspaceConfigs = await this.workspacesService.getWorkspaceConfigValue(workspaceId); if (workspaceConfigs.isAssetsDiscovery) { this.eventEmitter.emit('target.create', target); }

gemini-code-assist · 2026-03-03T07:11:56Z

core-api/src/modules/targets/targets.service.ts

+        const existingAsset = await transactionalEntityManager
+          .getRepository(Asset)
+          .findOne({
+            where: {
+              value,
+              target: { id: target.id },
+            },
+          });
+
+        if (!existingAsset) {
+          await transactionalEntityManager.getRepository(Asset).save({
+            id: randomUUID(),
+            target: { id: target.id },
+            value,
+            isPrimary: true,
+          });
+        }


This check for existingAsset appears to be redundant. Since the target is created within this same transaction, no Asset can be associated with it yet, so existingAsset will always be null. You can simplify this by removing the findOne call and the conditional check, and directly saving the new asset. The database unique constraint on (value, targetId) will prevent duplicates in any case.

await transactionalEntityManager.getRepository(Asset).save({ id: randomUUID(), target: { id: target.id }, value, isPrimary: true, });

* refactor(targets): combine logic create target in transaction * feat(targets): add bulk target creation endpoint * feat(targets): add bulk creation support

* feat(console, admin): add list users for administration * feat(console): redesign user detail sheet * fix(console): fix sorting for server datatable * refactor(console): restyle user-detail-sheet * feat(console): add confirm dialog for action ban * feat(console): add user detail section * fix(console): fix small typo in tls tab (#290) * feat(asset): add tls filter for asset * fix(core): fix asset test * fix(asset): fix based on bot reviews * fix(console): fix small typo in tls tab * fix(console): add missing tls for queryParams in asset context * fix(console): fix tls query hook in dashboard --------- Co-authored-by: Quang Vinh <32523515+l1ttps@users.noreply.github.com> * chore(deps): bump multer from 2.0.2 to 2.1.0 (#292) Bumps [multer](https://github.com/expressjs/multer) from 2.0.2 to 2.1.0. - [Release notes](https://github.com/expressjs/multer/releases) - [Changelog](https://github.com/expressjs/multer/blob/main/CHANGELOG.md) - [Commits](expressjs/multer@v2.0.2...v2.1.0) --- updated-dependencies: - dependency-name: multer dependency-version: 2.1.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(targets): create multiple targets (#291) * refactor(targets): combine logic create target in transaction * feat(targets): add bulk target creation endpoint * feat(targets): add bulk creation support * fix(console): move tabList into component to avoid out of context (#293) Co-authored-by: Quang Vinh <32523515+l1ttps@users.noreply.github.com> * fix(assets): select asset relations in query (#297) * refactor(ui): improve flow onboarding with first workspace creation and re-design settings ui (#299) * feat(console): add all workspaces navigation and improve 404 page UI * refactor(layout): extract header into dedicated HeaderBar component * refactor(console): add workspace-aware header layout * refactor(console): convert workspace creation to page and add route protection * refactor(console): update workspaces UI from table to card layout * feat(workspaces): add member and target counts to workspace list * refactor(settings): reorganize settings page with sidebar layout * feat(settings): add API keys management * refactor(settings): improve API key display layout * fix(screenshot-cell): add type assertion for screenshotPath * refactor(workspaces): use workspace selector hook * feat(auth): add session retry with exponential backoff * chore(agent): migrate ai agent * feat(router): add admin users route * feat(console): implement create user * feat(console): add change name, email and reset password in user detail * fix(console): fix duplicate tlsHosts in context * fix(console): use loading state of data table and improve client user type * fix(console): add admin route * feat(console): Implement role-based access control for settings tabs and sidebar menu items based on user roles. * style(console): update 'Add User' button to outline variant * refactor(console): move add user button to table toolbar * fix(console): add autoComplete to user detail input --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Quang Vinh <32523515+l1ttps@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: l1ttps <l1ttps443@gmail.com>

refactor(targets): combine logic create target in transaction

8bd7042

Merge branch 'main' into create-multiple-targets

850c7ac

gemini-code-assist bot reviewed Mar 3, 2026

View reviewed changes

l1ttps and others added 3 commits March 4, 2026 16:07

feat(targets): add bulk target creation endpoint

c1b8a29

feat(targets): add bulk creation support

36ce0cf

Merge branch 'main' into create-multiple-targets

4f40503

l1ttps changed the title ~~feat(targets): create multiple targets and using queue process~~ feat(targets): create multiple targets Mar 5, 2026

l1ttps merged commit de60133 into main Mar 5, 2026
9 checks passed

l1ttps added a commit that referenced this pull request Mar 7, 2026

feat(targets): create multiple targets (#291)

d58fb59

* refactor(targets): combine logic create target in transaction * feat(targets): add bulk target creation endpoint * feat(targets): add bulk creation support

l1ttps deleted the create-multiple-targets branch March 22, 2026 03:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(targets): create multiple targets#291

feat(targets): create multiple targets#291
l1ttps merged 5 commits intomainfrom
create-multiple-targets

l1ttps commented Mar 3, 2026

Uh oh!

gemini-code-assist bot commented Mar 3, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Mar 3, 2026

Uh oh!

gemini-code-assist bot Mar 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

l1ttps commented Mar 3, 2026

Uh oh!

gemini-code-assist bot commented Mar 3, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant