feat(user): implement users manager by mizhm · Pull Request #289 · oasm-platform/open-asm

mizhm · 2026-03-02T01:40:35Z

No description provided.

gemini-code-assist · 2026-03-02T01:40:52Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces robust user management capabilities to the console application, empowering administrators with a dedicated interface to oversee and control user accounts. It includes a new navigation entry, a dynamic user listing page, and a detailed user profile view that facilitates administrative actions like banning and role assignment. The changes also include an improvement to the underlying data table hook for more efficient parameter handling.

Highlights

User Management Interface: A new 'Admin' section has been added to the console's sidebar navigation, featuring a 'Users' submenu item. This provides a dedicated entry point for administrative user management.
User Listing and Details: New pages and components have been introduced to display a comprehensive list of users in a data table, complete with filtering, sorting, and pagination. Clicking on a user opens a detail sheet where administrators can view user information and perform actions.
Administrative Actions: The user detail sheet enables administrators to ban or unban users and change their roles (e.g., to 'admin' or 'user'), with immediate feedback via toast notifications.
Enhanced Data Table Hook: The useServerDataTable hook has been refactored to allow setting multiple table parameters (like page, pageSize, sortBy, sortOrder, and filter) simultaneously using a single setParams function, improving flexibility and reducing boilerplate.
Auth Client Integration: The better-auth/client/plugins admin client has been integrated into the authClient, and the User type has been extended to include administrative fields such as role, banned, banReason, and banExpires.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

console/src/components/common/layout/menu-bar.tsx
- Added a new 'Admin' menu item with a 'Users' submenu to the sidebar.
console/src/hooks/useServerDataTable.ts
- Refactored the setParam function to setParams to allow updating multiple data table parameters simultaneously.
- Updated all table handlers to use the new setParams function for consistency.
console/src/pages/admin/list-users.tsx
- Added a new page component to display a paginated, sortable, and filterable list of users using useServerDataTable.
- Implemented user data fetching and display, including user status (banned/active) and role badges.
console/src/pages/admin/user-detail-sheet.tsx
- Added a new sheet component to display detailed user information.
- Implemented functionality to ban/unban users and change user roles via mutations.
- Displayed user status, role, ban reason, and ban expiration date.
console/src/pages/admin/users.tsx
- Added a new wrapper page component for the user listing.
console/src/routers/index.tsx
- Configured new routes for the /admin/users page.
console/src/utils/authClient.ts
- Integrated the adminClient plugin from better-auth/client/plugins.
- Extended the User type to include role, banned, banReason, and banExpires properties for administrative purposes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copilot

Pull request overview

Adds an Admin “Users” management surface to the console using better-auth’s admin client plugin, including routing, navigation, and new pages for listing users and viewing/updating user status.

Changes:

Enable better-auth admin plugin in the console auth client and introduce a local User type.
Add /admin/users route + sidebar navigation entry, and implement Users page, list view, and detail/action sheet.
Refactor useServerDataTable to support setting multiple params at once via setParams.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
console/src/utils/authClient.ts	Enables `adminClient()` plugin and defines an extended `User` type used by the admin UI.
console/src/routers/index.tsx	Registers the new `/admin/users` route under the authenticated area.
console/src/pages/admin/users.tsx	Adds the top-level Admin Users page wrapper.
console/src/pages/admin/list-users.tsx	Implements server-driven user listing table and selection to open a detail sheet.
console/src/pages/admin/user-detail-sheet.tsx	Implements user detail display and admin actions (ban/unban, role change).
console/src/hooks/useServerDataTable.ts	Refactors param updates to a multi-field `setParams` helper.
console/src/components/common/layout/menu-bar.tsx	Adds “Admin → Users” entry to the sidebar navigation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

console/src/utils/authClient.ts

console/src/pages/admin/user-detail-sheet.tsx

console/src/pages/admin/list-users.tsx

console/src/routers/index.tsx

console/src/components/common/layout/menu-bar.tsx

gemini-code-assist

Code Review

This pull request introduces a user management feature, including a user list page and a user detail view with admin actions, along with new routes and components. A critical security vulnerability has been identified: the new 'Admin' menu section and the /admin/users route lack proper role-based access control (RBAC) on the frontend, making them accessible to any authenticated user and exposing sensitive data. Additionally, the review highlighted areas for improvement in the new components, including suboptimal initial loading state handling in list-users.tsx, incomplete query invalidation in user-detail-sheet.tsx which could lead to stale data, and a minor issue with accessing a user's name for the avatar fallback.

console/src/routers/index.tsx

console/src/components/common/layout/menu-bar.tsx

console/src/pages/admin/list-users.tsx

gemini-code-assist · 2026-03-02T01:46:34Z

console/src/pages/admin/user-detail-sheet.tsx

+    },
+    onSuccess: () => {
+      toast.success(`User has been ${aUser?.banned ? 'unbanned' : 'banned'}.`);
+      return queryClient.invalidateQueries({ queryKey: ['user', aUser?.id] });


After successfully updating a user's status (ban/unban), the list of users on the main page should be updated to reflect this change. Currently, only the specific user query (['user', aUser?.id]) is invalidated. You should also invalidate the users list query to ensure the UI is consistent.

queryClient.invalidateQueries({ queryKey: ['users'] }); return queryClient.invalidateQueries({ queryKey: ['user', aUser?.id] });

gemini-code-assist · 2026-03-02T01:46:34Z

console/src/pages/admin/user-detail-sheet.tsx

+    },
+    onSuccess: () => {
+      toast.success('User role updated.');
+      return queryClient.invalidateQueries({ queryKey: ['user', aUser?.id] });


After successfully updating a user's role, the list of users on the main page should be updated to reflect this change. Currently, only the specific user query (['user', aUser?.id]) is invalidated. You should also invalidate the users list query to ensure the UI is consistent.

queryClient.invalidateQueries({ queryKey: ['users'] }); return queryClient.invalidateQueries({ queryKey: ['user', aUser?.id] });

console/src/pages/admin/user-detail-sheet.tsx

* feat(asset): add tls filter for asset * fix(core): fix asset test * fix(asset): fix based on bot reviews * fix(console): fix small typo in tls tab * fix(console): add missing tls for queryParams in asset context * fix(console): fix tls query hook in dashboard --------- Co-authored-by: Quang Vinh <32523515+l1ttps@users.noreply.github.com>

Bumps [multer](https://github.com/expressjs/multer) from 2.0.2 to 2.1.0. - [Release notes](https://github.com/expressjs/multer/releases) - [Changelog](https://github.com/expressjs/multer/blob/main/CHANGELOG.md) - [Commits](expressjs/multer@v2.0.2...v2.1.0) --- updated-dependencies: - dependency-name: multer dependency-version: 2.1.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* refactor(targets): combine logic create target in transaction * feat(targets): add bulk target creation endpoint * feat(targets): add bulk creation support

Co-authored-by: Quang Vinh <32523515+l1ttps@users.noreply.github.com>

…nd re-design settings ui (#299) * feat(console): add all workspaces navigation and improve 404 page UI * refactor(layout): extract header into dedicated HeaderBar component * refactor(console): add workspace-aware header layout * refactor(console): convert workspace creation to page and add route protection * refactor(console): update workspaces UI from table to card layout * feat(workspaces): add member and target counts to workspace list * refactor(settings): reorganize settings page with sidebar layout * feat(settings): add API keys management * refactor(settings): improve API key display layout * fix(screenshot-cell): add type assertion for screenshotPath * refactor(workspaces): use workspace selector hook

console/src/routers/index.tsx

console/src/components/common/layout/menu-bar.tsx

kilo-code-bot · 2026-03-14T02:59:52Z

console/src/hooks/useServerDataTable.ts

+        [setParams],
      ),
      setFilter: useCallback(
        (v: string) => {


SUGGESTION: setFilter should implement debouncing

For search/filter functionality, consider adding debounce to prevent excessive API calls while user is typing.

kilo-code-bot · 2026-03-14T02:59:52Z

console/src/hooks/useServerDataTable.ts

-            setParam('filter', v);
-          }
+          if (filter === v) return;
+          setParams({


SUGGESTION: Consider resetting page on filter change

When filter changes, it's common practice to reset to page 1 since the filtered results may have different pagination. This is already implemented, which is good.

kilo-code-bot · 2026-03-14T02:59:52Z

console/src/pages/admin/add-user-dialog.tsx

+const formSchema = z.object({
+  name: z.string().min(1, 'Name is required'),
+  email: z.string().min(1, 'Email is required').email('Invalid email address'),
+  password: z.string().min(8, 'Password must be at least 8 characters'),


SUGGESTION: Add password confirmation field for better UX and security

The password field lacks a confirmation field which is standard practice for user creation to prevent typos. Consider adding a 'confirmPassword' field with validation that it matches the password field.

kilo-code-bot · 2026-03-14T02:59:52Z

console/src/pages/admin/add-user-dialog.tsx

+                <FormItem>
+                  <FormLabel>Password</FormLabel>
+                  <FormControl>
+                    <Input


SUGGESTION: Consider showing password strength indicator

For better user experience, consider adding a password strength indicator to help users create stronger passwords.

kilo-code-bot · 2026-03-14T02:59:52Z

console/src/pages/admin/add-user-dialog.tsx

+                  <FormControl>
+                    <Input
+                      type="password"
+                      placeholder="Min. 8 characters"


SUGGESTION: Add 'show password' toggle for accessibility

Consider adding a toggle to show/hide the password field content for better accessibility and user experience.

kilo-code-bot · 2026-03-14T03:00:37Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

… type

…and sidebar menu items based on user roles.

mizhm added 2 commits January 30, 2026 22:48

feat(console, admin): add list users for administration

e2b387f

feat(console): redesign user detail sheet

8b72e3e

Copilot AI review requested due to automatic review settings March 2, 2026 01:40

Copilot started reviewing on behalf of mizhm March 2, 2026 01:40 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

gemini-code-assist bot reviewed Mar 2, 2026

View reviewed changes

l1ttps and others added 5 commits March 2, 2026 02:05

Merge branch 'main' into feat/user-management

2115160

fix(console): fix sorting for server datatable

d442101

refactor(console): restyle user-detail-sheet

af5c8ad

feat(console): add confirm dialog for action ban

668207b

feat(console): add user detail section

c078b23

l1ttps changed the title ~~Feat/user management~~ feat(user): implement users manager Mar 7, 2026

mizhm and others added 9 commits March 7, 2026 16:12

feat(targets): create multiple targets (#291)

d58fb59

* refactor(targets): combine logic create target in transaction * feat(targets): add bulk target creation endpoint * feat(targets): add bulk creation support

fix(console): move tabList into component to avoid out of context (#293)

ea3e0f0

Co-authored-by: Quang Vinh <32523515+l1ttps@users.noreply.github.com>

fix(assets): select asset relations in query (#297)

67d6060

feat(auth): add session retry with exponential backoff

6fdf3e5

chore(agent): migrate ai agent

197d979

Merge branch 'main' into feat/user-management

781115d

github-code-quality bot found potential problems Mar 7, 2026

View reviewed changes

console/src/routers/index.tsx Fixed Show fixed Hide fixed

l1ttps and others added 6 commits March 7, 2026 16:19

feat(router): add admin users route

5b671e5

feat(console): implement create user

85166f5

feat(console): add change name, email and reset password in user detail

de66cdb

Merge branch 'main' into feat/user-management

72fa0f8

Merge branch 'main' into feat/user-management

5f09752

fix(console): fix duplicate tlsHosts in context

c7807d2

kilo-code-bot bot reviewed Mar 14, 2026

View reviewed changes

mizhm and others added 7 commits March 14, 2026 17:26

fix(console): use loading state of data table and improve client user…

641d61d

… type

Merge branch 'main' into feat/user-management

783f149

fix(console): add admin route

efe4501

feat(console): Implement role-based access control for settings tabs …

9246a11

…and sidebar menu items based on user roles.

style(console): update 'Add User' button to outline variant

dd9b36b

refactor(console): move add user button to table toolbar

fbb0359

fix(console): add autoComplete to user detail input

561a14d

l1ttps merged commit 01dd1cb into main Mar 16, 2026
15 checks passed

l1ttps deleted the feat/user-management branch March 22, 2026 03:23

Conversation

mizhm commented Mar 2, 2026

Uh oh!

gemini-code-assist bot commented Mar 2, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kilo-code-bot bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kilo-code-bot bot commented Mar 14, 2026 •

edited

Loading