Skip to content
This repository was archived by the owner on Jul 3, 2025. It is now read-only.

Merge beta to l10n#23

Merged
seanbudd merged 3 commits into
betafrom
beta
Jul 18, 2024
Merged

Merge beta to l10n#23
seanbudd merged 3 commits into
betafrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

No description provided.

…thin a contenteditable. Required to report addresses in outlook.com / Modern Outlook To/CC/BCC fields. (#16856)

Summary of the issue:
In outlook.com or Modern Outlook (Monarch) app, when arrowing through the To/CC/BCC fields, NVDA only reports button graphic for email addresses, and does not report the actual name/ address.
This is because NVDA knows it is in a contenteditable / editable text field, and assumes that all the content can be moved through by character, and therefore does not include meta info such as name on ancestor elements.
However, in this case, the addresses are actually on-contenteditable buttons within the contenteditable, which means that each button only takes up one character stop, and its content does not contain the name / address.
Description of user facing changes
NVDA now reports addresses when arrowing through To/CC/BCC fields in outlook.com / the Modern Outlook app.
Description of development approach
In ia2TextMozilla compound textInfo: conrolFields or objects that are non-contenteditable (don't have the editable state) are within a contenteditable (do have the editable state), have their 'content' key set to the object's name. Which forces NVDA to report the name as the content.
…table wi…" (#16859)

 reverts commit e7266c7.
Reverts #16856
There were valid system tests that failed with the merging of pr #16856This
…To/CC/BCC fields (#16870)

In outlook.com or Modern Outlook (Monarch) app, when arrowing through the To/CC/BCC fields, NVDA only reports button graphic for email addresses, and does not report the actual name/ address.
This is because NVDA knows it is in a contenteditable / editable text field, and assumes that all the content can be moved through by character, and therefore does not include meta info such as name on ancestor elements.

However, in this case, the addresses are actually on-contenteditable buttons within the contenteditable, which means that each button only takes up one character stop, and its content does not contain the name / address.

Description of user facing changes

NVDA now reports addresses when arrowing through To/CC/BCC fields in outlook.com / the Modern Outlook app.

Description of development approach

In ia2TextMozilla compound textInfo: conrolFields or objects that are non-contenteditable (don't have the editable state) are within a contenteditable (do have the editable state), have their 'content' key set to the object's name. Which forces NVDA to report the name as the content.
@seanbudd seanbudd merged commit 1f5cc1e into nvaccess:beta Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants