ia2TextMozilla: report addresses in outlook.com and Modern Outlook's To/CC/BCC fields #16870
Conversation
…thin a contenteditable. Required to report addresses in outlook.com / Modern Outlook To/CC/BCC fields.
…tons as links actually don't get the editable state.
WalkthroughThis update enhances NVDA's ability to report recipient names in Outlook.com/modern Outlook's To/CC/BCC fields by ensuring that labeled buttons are announced correctly. Additionally, it improves the handling of add-on installation failures in NVDA. Changes
Assessment against linked issues
Recent review detailsConfiguration used: .coderabbit.yml Files selected for processing (2)
Additional context usedPath-based instructions (2)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
user_docs/en/changes.md (2)
84-84: Ensure consistency and clarity in the documentation.The entry for the change related to reporting addresses in To/CC/BCC fields could be expanded for clarity. It should explicitly mention that this is an improvement over previous functionality, as detailed in the PR description.
- * NVDA will report addresses when arrowing through To/CC/BCC fields in outlook.com / Modern Outlook. (#16856) + * Improved: NVDA now reports email addresses in addition to graphics when arrowing through To/CC/BCC fields in outlook.com and Modern Outlook, enhancing user accessibility. (#16856)
84-84: Grammar and style check for documentation.The change log entries are well-written, but they should follow the one sentence per line style guideline. This helps in maintaining readability and makes future diffs cleaner and easier to understand.
- * NVDA will report addresses when arrowing through To/CC/BCC fields in outlook.com / Modern Outlook. (#16856) - * NVDA now handles add-on installation failures more gracefully. (#16704) + * NVDA will report addresses when arrowing through To/CC/BCC fields in outlook.com / Modern Outlook. (#16856) + * NVDA now handles add-on installation failures more gracefully. (#16704)
This is an improvement over PR #16856 to ensure that system tests continue to pass.
the difference being that the logic has been tightened to only expose name as content for buttons that are non-contenteditable within a contenteditable. Previously it was also matching on links, which seem to actually never get the editable state.
Link to issue number:
Fixes #16631
Replaces PR #16856
Summary of the issue:
In outlook.com or Modern Outlook (Monarch) app, when arrowing through the To/CC/BCC fields, NVDA only reports button graphic for email addresses, and does not report the actual name/ address.
This is because NVDA knows it is in a contenteditable / editable text field, and assumes that all the content can be moved through by character, and therefore does not include meta info such as name on ancestor elements.
However, in this case, the addresses are actually on-contenteditable buttons within the contenteditable, which means that each button only takes up one character stop, and its content does not contain the name / address.
Description of user facing changes
NVDA now reports addresses when arrowing through To/CC/BCC fields in outlook.com / the Modern Outlook app.
Description of development approach
In ia2TextMozilla compound textInfo: conrolFields or objects that are non-contenteditable (don't have the editable state) are within a contenteditable (do have the editable state), have their 'content' key set to the object's name. Which forces NVDA to report the name as the content.
Testing strategy:
In outlook.com / Modern Outlook, created a new email message. Focused on the To field and inserted several email addresses. Then arrowed between them with the left and right arrow keys, ensuring that the addresses were reported.
Known issues with pull request:
Reporting of these addresses is still quite verbose. E.g. "button available Michael Curran mick@nvaccess.org graphic available"
And then arrowing onto another one:
"out of graphic out of button button available Gerald Hartig gerald@nvaccess.org"
Perhaps outlook.com / Modern Outlook could hide the inner graphic from the accessibility tree. And or, NVDA could somehow for non-contenteditable fields, generate a control field that does not require reporting out of at the end. E.g. like a checkbox or separator.
But at very least, this pr is a necessary improvement as before the addresses were not being reported at all.
Code Review Checklist:
Summary by CodeRabbit
New Features
Improvements