Skip to content

Revert "ia2TextMozilla: expose name as content for any non-contenteditable within a contenteditable. Required to report addresses in outlook.com / Modern Outlook To/CC/BCC fields."#16859

Merged
michaelDCurran merged 1 commit into
betafrom
revert-16856-i16631
Jul 15, 2024
Merged

Conversation

@michaelDCurran

@michaelDCurran michaelDCurran commented Jul 15, 2024 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Reverts #16856
There were valid system tests that failed with the merging of pr #16856

Summary by CodeRabbit

  • Bug Fixes
    • Removed logic that caused NVDA to report addresses in To/CC/BCC fields as labelled buttons in Outlook.com/Modern Outlook. This improves the accuracy and reliability of content reporting in these fields.

@michaelDCurran michaelDCurran requested a review from a team as a code owner July 15, 2024 07:41
@michaelDCurran michaelDCurran requested review from seanbudd and removed request for a team July 15, 2024 07:41
@coderabbitai

coderabbitai Bot commented Jul 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The recent update to NVDA involves removing the logic that allowed the software to report the label (name) of email addresses in To/CC/BCC fields as content within a parent contenteditable context in Outlook.com/Modern Outlook. This change ensures that NVDA no longer treats these addresses as labelled buttons, simplifying the user experience by not reporting this additional information.

Changes

File(s) Change Summary
source/NVDAObjects/IAccessible/ia2TextMozilla.py Removed logic for handling addresses in To/CC/BCC fields as labelled buttons in Outlook.com/Modern Outlook.
user_docs/en/changes.md Documented the removal of the functionality related to NVDA reporting addresses in Outlook.
Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e7266c7 and 5d66f7d.

Files selected for processing (2)
  • source/NVDAObjects/IAccessible/ia2TextMozilla.py (1 hunks)
  • user_docs/en/changes.md (1 hunks)
Files skipped from review due to trivial changes (2)
  • source/NVDAObjects/IAccessible/ia2TextMozilla.py
  • user_docs/en/changes.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@michaelDCurran michaelDCurran merged commit 4ef1f68 into beta Jul 15, 2024
@michaelDCurran michaelDCurran deleted the revert-16856-i16631 branch July 15, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd Awaiting requested review from seanbudd seanbudd is a code owner automatically assigned from nvaccess/developers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@michaelDCurran