This repository was archived by the owner on Jul 3, 2025. It is now read-only.
Merge latest beta translations#17
Merged
Merged
Conversation
Merge master to beta
…dings Follow up to nvaccess#12816 Closes nvaccess#12387 Must be merge commit Performed the following: git add --renormalize . git commit -m "normalize line endings" Added the commit to .git-blame-ignore-revs Testing Confirmed testing by ensuring the diff is empty git diff --ignore-cr-at-eol origin/master normalize-all-line-endings
…evious character is a line feed. (nvaccess#16763) Fixup of nvaccess#16745. Summary of the issue: In my work on nvaccess#16745, I neglected to consider an empty line after a line feed. In that case, adjusting for the line end caused NVDA to read from the previous line instead of the empty one. Description of user facing changes In Firefox, NVDA no longer speaks the previous line when the caret is on the last line and the last line is empty. However, this does not need a change log entry because this bug never shipped in release. Description of development approach Don't set the _isInsertionPointAtEndOfLine flag to True if the previous character is a line feed. This prevents the line end adjustment. Because this additional check makes the code a little more complex, I refactored this code into a helper method.
Fixes nvaccess#16735 Summary of the issue: This adds Turkish grade 2 braille table to NVDA interface. Description of user facing changes Users will be able to use the table provided in NVDA Description of development approach Modified the brailleTables.py.
Fixes nvaccess#14817 Summary of the issue: Our linting system has the following issues: we are stuck on an old version of flake8, as the flake8tabs module is no longer being updated we can't perform automatic lint fixes Ruff is becoming more maintained than flake8 Description of user facing changes The entire repository is linted with Ruff, rather than diffs Developers can now automatically fix certain linting issues with runlint.bat If using pre-commit hooks, linting is automatically applied: pre-commit.com/#usage CodeRabbit now scans code using our Ruff config Description of development approach integrate Ruff, migrate flake8 config Update AppVeyor scripts to use ruff add pre commit hook support for ruff update linting docs
Lint the repository with Ruff This is a follow up for nvaccess#16751 Must be merge commit not squash merge Using nvaccess#16751, the following commands were applied: ruff check --fix to apply automatic fixes ruff check --add-noqa to add no-qa comments to all lint failures, so that issues that can't be automatically fixed don't trigger future failures
2024.3 Final master to beta merge
…l10n Merge translations from svn
… doesn't support 2 channels. (nvaccess#16771) Fixes nvaccess#16770. Summary of the issue: WasapiWavePlayer.setVolume assumes that the audio device supports 2 channels. Some devices do not. This causes an exception when trying to set the second channel. Description of user facing changes Playing NVDA sounds no longer fails on a mono audio device. Description of development approach Catch E_INVALIDARG which is the documented error code for this situation. Alternatively, we could check the number of channels before trying to set, but I don't think there's any benefit to that approach and that would require more C++ code. I also removed _wasPlay_errcheck. That was never actually called and was unnecessary because raising an exception for a failure is already handled by setting .restype to HRESULT. Furthermore, _wasPlay_errcheck was raising WindowsError with the wrong parameters, so it wouldn't have been what we wanted even if it had worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.