Turkish braille table grade 2 by zstanecic · Pull Request #16764 · nvaccess/nvda

zstanecic · 2024-06-27T16:59:59Z

Link to issue number:

Fixes #16735

Summary of the issue:

This adds Turkish grade 2 braille table to NVDA interface.

Description of user facing changes

Users will be able to use the table provided in NVDA

Description of development approach

Modified the brailleTables.py.

Testing strategy:

Tested from source with the braille display that the braille table works

Known issues with pull request:

None known

Code Review Checklist:

[x ] Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
[x ] Testing:
- Unit tests
- System (end to end) tests
- Manual testing
[x ] UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
[x ] API is compatible with existing add-ons.
[x ] Security precautions taken.

Summary by CodeRabbit

New Features
- Added support for Turkish grade 2 Braille table with contracted Braille.
- Added support for Setswana grade 1 Braille table.
Documentation
- Updated user documentation to reflect the new Turkish grade 2 Braille table.
- Other documentation updates include support for the Karakalpak language and various version updates.
Updates
- Updated Braille tables for several languages and scripts.
- Upgraded dependencies including LibLouis, eSpeak, fast_diff_match_patch, NSIS, Python Markdown, and nh3 to their latest versions.

coderabbitai · 2024-06-27T17:00:06Z

Walkthrough

The updates introduce support for Turkish Grade II Braille, including contracted Braille (tr-g2.ctb), and Setswana Grade I Braille (tsn-za-g1.ctb). Additionally, documentation mentions updates across various software components, highlighting the evolving support and improved inclusivity for different languages.

Changes

Files	Change Summary
`source/brailleTables.py`	Added new Braille tables for Turkish Grade II and Setswana Grade I.
`user_docs/en/changes.md`	Documented Turkish Grade II Braille addition to Liblouis and various software updates.

Sequence Diagram(s)

Since the changes are primarily about adding new Braille tables and documentation, no significant control flow adjustments or new features necessitating sequence diagrams are present.

Possibly related issues

Request for Turkish Grade II table #16735: This change addresses the request for enabling the Turkish Grade II Braille table in NVDA by supporting the addition of the tr-g2.ctb file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

zstanecic · 2024-06-27T17:21:16Z

If something needs to be corrected here, let me anybody know.

oguzugur28 · 2024-06-28T16:13:07Z

Hi all,
To adding Turkish Grade II Braille table to NVDA was requested by me via email.
I'm appriciates to your excellent work.
I can check fix related about Turkish Grade II Braille table, but for now, I don't know that how i can check it? My question may be so easy but unfortunately I'm not a software expert. If you can show to test ways, I would be test it.
Best,

zstanecic · 2024-06-28T16:15:52Z

Hi Oguz, You can install the latest alpha snapshot, or run it in a portable copy, and test it there if you have a braille display. Best. Zvonimir

oguzugur28 · 2024-06-28T16:21:26Z

Hi Zvonimir,
Thanks for your answer.
I've braille display. Where I can find the latest alpha snapshot?
Best,

seanbudd · 2024-07-01T00:14:42Z

@oguzugur28 - https://www.nvaccess.org/files/nvda/snapshots/

Added turkish braille table as per opened issue

bae97ab

zstanecic requested a review from a team as a code owner June 27, 2024 16:59

zstanecic requested a review from seanbudd June 27, 2024 17:00

coderabbitai Bot reviewed Jun 27, 2024

View reviewed changes

Comment thread user_docs/en/changes.md Outdated

Comment thread user_docs/en/changes.md

Update user_docs/en/changes.md

0f35ff1

seanbudd approved these changes Jun 28, 2024

View reviewed changes

seanbudd merged commit 3875f29 into nvaccess:master Jun 28, 2024

coderabbitai Bot mentioned this pull request Sep 27, 2024

Set default input and translation tables according to NVDA's language #17222

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Turkish braille table grade 2#16764

Turkish braille table grade 2#16764
seanbudd merged 2 commits into
nvaccess:masterfrom
zstanecic:turkish-G2

zstanecic commented Jun 27, 2024 •

edited by seanbudd

Loading

Uh oh!

coderabbitai Bot commented Jun 27, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

zstanecic commented Jun 27, 2024

Uh oh!

oguzugur28 commented Jun 28, 2024

Uh oh!

zstanecic commented Jun 28, 2024 via email

Uh oh!

oguzugur28 commented Jun 28, 2024

Uh oh!

seanbudd commented Jul 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

zstanecic commented Jun 27, 2024 • edited by seanbudd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of user facing changes

Description of development approach

Testing strategy:

Known issues with pull request:

Code Review Checklist:

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zstanecic commented Jun 27, 2024

Uh oh!

oguzugur28 commented Jun 28, 2024

Uh oh!

zstanecic commented Jun 28, 2024 via email

Uh oh!

oguzugur28 commented Jun 28, 2024

Uh oh!

seanbudd commented Jul 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zstanecic commented Jun 27, 2024 •

edited by seanbudd

Loading

coderabbitai Bot commented Jun 27, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)