-
-
Notifications
You must be signed in to change notification settings - Fork 784
Line ending normalization #12387
Copy link
Copy link
Closed
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersp4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityrelease/blockingthis issue blocks the milestone releasethis issue blocks the milestone releasetriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Milestone
Metadata
Metadata
Assignees
Labels
audience/nvda-devPR or issue is relevant to NVDA / Add-on developersPR or issue is relevant to NVDA / Add-on developersp4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityhttps://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priorityrelease/blockingthis issue blocks the milestone releasethis issue blocks the milestone releasetriagedHas been triaged, issue is waiting for implementation.Has been triaged, issue is waiting for implementation.
Type
Fields
Give feedbackNo fields configured for issues without a type.
The NVDA code base uses a mix of CRLF and LF style line endings, with the preference being CRLF. LF style endings have been introduced prior to lint checking, and can causes issues when moving code or making changes. Many IDEs will normalize the line endings when editing files, causing larger than intended diffs in PRs.
In order to tackle part of many linting issues noted in #12261, we can normalize all files to use LF in the NVDA code base. This commit can be ignored with git blame by introducing a git ignore revs file.
The concerns around reviewing mass linting here can be ignored as we can review an empty diff quickly with
git diff --ignore-cr-at-eol.*.t2tfiles so translators aren't affectedgit add --renormalize .git diff --ignore-cr-at-eoland ensure there is an empty diff.- normalize all line endings to LF #16754