Revert minhook back to version 1.2.2#8456
Merged
Merged
Conversation
added 4 commits
June 27, 2018 16:06
Collaborator
Author
|
Note that this does not revert anything in the readme as it turns out that I forgot to update the readme earlier. |
Member
|
Has a build with reverted minhook been successfully run on a system
where the issue was noticed?
|
michaelDCurran
approved these changes
Jun 28, 2018
Member
|
This should go straight to master as this is just reverts? |
Collaborator
Author
|
Yes, I'm ok with that. Note that I didn't touch the changes file yet, do you want me to do that as part of this pr? |
10 tasks
feerrenrut
pushed a commit
that referenced
this pull request
Jan 10, 2022
Related to #8420 Summary: NVDA has been using minhook to hook several Windows APIs, particularly related to the display model. However, the version of minhook currently in use is very old. An update was previously attempted but failed and was reverted in #8456. Microsoft always had their own hooking library, but it was closed source in the past. Now it is open, it offers us the following benefits: - Support for hooking on ARM64, which should make the display model work. - Better documented and more widely used than Minhook - More modern than Minhook Description of change: - Remove Minhook and replace with Detours
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #8420
Reverts #8142
Summary of the issue:
Minhook 1.3.3 is causing issues for Windows 7 users.
Description of how this pull request fixes the issue:
This reverts Minhook back to version 1.2.2, while reapplying the hde source file name fix from #8410
Testing performed:
Made sure that NVDA builds and runs correctly.
Known issues with pull request:
None
Change log entry:
None, as this fixes a regression that is not yet in a release