Minhook sconscript: correct case of hde source files#8410
Merged
Conversation
… 10 builds seem to now be case-sensitive.
feerrenrut
approved these changes
Jun 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
On recent Windows 10 insider builds, it seems that paths are now case-sensitive. NVDA's build system mostly uses case-sensitive paths, except for a reference to some hde source files in minHook, where 'hde' is incorrectly capitalized. This is causing the building of NvDA to fail on recent Windows 10 insider builds.
Description of how this pull request fixes the issue:
The two paths have been changed to reflect their proper case in the file system.
Testing performed:
NVDA now builds on the affected builds of Windows 10, and also still builds on appveyor.
Known issues with pull request:
None.
Change log entry:
None.