Skip to content

Update espeak version#7846

Merged
michaelDCurran merged 17 commits into
masterfrom
updateEspeak
Jul 19, 2018
Merged

Update espeak version#7846
michaelDCurran merged 17 commits into
masterfrom
updateEspeak

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

Summary of the issue:

Update to the latest development version of espeak.

Testing performed:

Built nvda locally and on buildsystem.
Ran NVDA with espeak set as the synthesizer.

Built NVDA with emoji dictionaries. Confirmed that the fix in PR: "Remove all eSpeak emoji dictsource files #7810" is still required.

Known issues with pull request:

When emoji dictionaries are included, recent crashes with hindi and tamil symbols still occur.

Change log entry:

Changes:
eSpeak has been updated to version...

feerrenrut added a commit that referenced this pull request Dec 11, 2017
Merge branch 'updateEspeak' into next
@feerrenrut

Copy link
Copy Markdown
Contributor Author

I have pushed a further update Espeak. This builds, and passes some basic smoke tests (running from source, changing language and voice)

@michaelDCurran michaelDCurran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must remember to keep updating the espeak version string in nvdaHelper/espeak/config.h. Right now I think it says 1.49.1dev, but I think it is 1.49.2. The version seems to be hardcoded through out eSpeak's various platform files which we don't use. But I think the best place to always check is in its configure.ac.

@feerrenrut

Copy link
Copy Markdown
Contributor Author

Ah yes, that is a good point, and easy to forget. The version I have pushed is 1.49.3-dev. I have updated the version string now.

feerrenrut added a commit that referenced this pull request Jan 30, 2018
Merge remote-tracking branch 'origin/updateEspeak' into next
michaelDCurran added a commit that referenced this pull request Mar 28, 2018
eSpeak-ng submodule is now at: 8a61f0d2108df289d713e0d74273dbfebbf23776
espeak no longer freezes with emoji files present in the known cases, so
reintroduce them. This undoes the mitigation in #7810.
@feerrenrut

Copy link
Copy Markdown
Contributor Author

I have updated this branch. The new version no longer deletes emoji files. With the emoji support compiled into the espeak dictionaries, I am no longer able to reproduce the freezes that were previously occurring.

michaelDCurran
michaelDCurran previously approved these changes Apr 9, 2018
@derekriemer

Copy link
Copy Markdown
Collaborator

@feerrenrut Is this ready for an incubation period?

@feerrenrut

Copy link
Copy Markdown
Contributor Author

michaelDCurran found a regression in the way certain English words are being spoken and is investigating. I'll update to the latest Dev version again next week and see if it is better.

michaelDCurran added a commit that referenced this pull request Apr 13, 2018
@michaelDCurran

michaelDCurran commented Apr 13, 2018

Copy link
Copy Markdown
Member

I have incubated this. However, i'd like to get peoples' opinions on a possible change in eSpeak english.
To me, words like 'selected" and "return" and "recycle" now sound strange.
For example, both "selected" and "selectered" now sound identical. Similarly, "return" now sounds more like "rer turn" rather than "ree turn".
I have tracked down the change to espeak-ng/espeak-ng@223ff9c. Where "return" is now rendered in espeak phonemes as "r@t'3:n" rather than "rI2t'3:n". Similarly, "selected" is now rendered in eSpeak phonemes as "sI2l'Ekt@d" rather than "sI2l'EktI2d".
Clearly this commit was very deliberate, so perhaps my issue with it is rather subjective.

@beqabeqa473

beqabeqa473 commented Apr 13, 2018 via email

Copy link
Copy Markdown
Contributor

@michaelDCurran

michaelDCurran commented Apr 13, 2018 via email

Copy link
Copy Markdown
Member

@beqabeqa473

beqabeqa473 commented Apr 13, 2018 via email

Copy link
Copy Markdown
Contributor

@michaelDCurran

michaelDCurran commented Apr 13, 2018 via email

Copy link
Copy Markdown
Member

michaelDCurran added a commit that referenced this pull request Apr 30, 2018
@beqabeqa473

Copy link
Copy Markdown
Contributor

hi.

please update to latest master to solve some of very annoying bugs in russian language.

also, i am facing an issue in georgian language, when reading text in cyrilic such as
из за
nvda gives an error.

could you please look in to that?

michaelDCurran added a commit that referenced this pull request May 3, 2018
michaelDCurran added a commit that referenced this pull request May 8, 2018
@derekriemer

Copy link
Copy Markdown
Collaborator

That fixed it!

@beqabeqa473

Copy link
Copy Markdown
Contributor

hi.

please update espeak to fix some russian things again.

michaelDCurran added a commit that referenced this pull request May 16, 2018
@michaelDCurran

Copy link
Copy Markdown
Member

I'm going to merge this pr with espeak at commit e7e59f9. There does not seem to be an eSpeak release coming any time soon.

@michaelDCurran michaelDCurran merged commit aff3c91 into master Jul 19, 2018
@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 19, 2018
@zstanecic

Copy link
Copy Markdown
Contributor

Hi michael!
please revert this pull request, because this commit brokes the macedonian language. Ot brokes ancient greek and macedoniann, i.e these languages are completelly unusable.
it makes conflicts with the language naming, see armenian language.
Thanks!

@michaelDCurran

michaelDCurran commented Jul 19, 2018 via email

Copy link
Copy Markdown
Member

@zstanecic

zstanecic commented Jul 19, 2018 via email

Copy link
Copy Markdown
Contributor

@michaelDCurran

michaelDCurran commented Jul 19, 2018 via email

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants