Remove all eSpeak emoji dictsource files#7810
Merged
Merged
Conversation
…hese cause crashes at runtime for many languages.
Collaborator
|
code looks fine to me. |
|
Does this need any changes to the what's new docs etc?
Brian
|
feerrenrut
approved these changes
Dec 3, 2017
|
I see no update to Master this morning only in the RC so wondered if this
had failed somehow??
Brian
|
Contributor
|
Thanks @Brian1Gaff. This branch targeted the RC specifically. The RC will be merged back to master, and master back to next. This will ensure that all branches get these changes. |
Merged
feerrenrut
added a commit
that referenced
this pull request
Apr 9, 2018
espeak no longer freezes with emoji files present in the known cases, so reintroduce them. This undoes the mitigation in #7810.
michaelDCurran
pushed a commit
that referenced
this pull request
Jul 19, 2018
* Update eSpeak-ng to 1.49.3-dev eSpeak-ng submodule is now at: 8a61f0d2108df289d713e0d74273dbfebbf23776 * Don't delete emoji files for espeak espeak no longer freezes with emoji files present in the known cases, so reintroduce them. This undoes the mitigation in #7810. * eSpeak synthDriver: provide text to eSpeak as utf8 as otherwise adjacent emojis will not be combined. * Update to latest eSpeak master. This addresses the pronunciation of words like return and selected. as espeak-ng/espeak-ng@223ff9c has been reverted. * Upgrade to latest eSpeak master * Update eSpeak to latest master. Most notably some improvements to Russian. * Update espeak to latest master. Fixes #8231 * Update eSpeak to latest master * Update to latest eSpeak master * Minhook sconscript: correct case of hde source files as newer windows 10 builds seem to now be case-sensitive. * Upgrade to latest espeak master * Update What's new and readme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #7805
Summary of the issue:
Currently many of the emoji ditsource files in eSpeak cause freezes or crashes at runtime.
Description of how this pull request fixes the issue:
This PR removes all _emoji dictsource files from eSpeak before compiling the dictionaries.
Testing performed:
Ran NVDA and had it speak the offending Indian characters from #7805. It no longer freezes.
Known issues with pull request:
No emoji support for any language. However, this support was far from great as it repeted symbols, or announced junk at the end, or... froze.
Change log entry:
changes From rc3: